[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2019-05-16 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841862#comment-16841862 ] Lucene/Solr QA commented on LUCENE-8326: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2019-05-16 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841220#comment-16841220 ] Alessandro Benedetti commented on LUCENE-8326: -- Anyone interested in helping me in

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-06-19 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516909#comment-16516909 ] Alessandro Benedetti commented on LUCENE-8326: -- Latest Jenkins failure doesn't seem to be

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-06-07 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504780#comment-16504780 ] Lucene/Solr QA commented on LUCENE-8326: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-06-06 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503705#comment-16503705 ] Alessandro Benedetti commented on LUCENE-8326: -- I just attached a revised patch and Pull

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-06-06 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503148#comment-16503148 ] Alessandro Benedetti commented on LUCENE-8326: -- Ok Robert, I see your point. I wouldn't

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-06-06 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503137#comment-16503137 ] Robert Muir commented on LUCENE-8326: - I feel the same way as before: we shouldn't split up a class

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-06-06 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503094#comment-16503094 ] Alessandro Benedetti commented on LUCENE-8326: -- Any consideration on my answer from the

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-26 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491601#comment-16491601 ] Alessandro Benedetti commented on LUCENE-8326: -- {color:#FF}Failed{color} - 

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-26 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491594#comment-16491594 ] Lucene/Solr QA commented on LUCENE-8326: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-25 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490843#comment-16490843 ] Alessandro Benedetti commented on LUCENE-8326: --

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-25 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490827#comment-16490827 ] Dawid Weiss commented on LUCENE-8326: - This means the relative cutoff is essentially setting the

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-25 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490575#comment-16490575 ] Alessandro Benedetti commented on LUCENE-8326: -- Hi [~dweiss], I am fixing the patch! In the

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-25 Thread Dawid Weiss (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490523#comment-16490523 ] Dawid Weiss commented on LUCENE-8326: - Ciao Alessandro. Just FYI: I've committed two (rather small)

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-24 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489291#comment-16489291 ] Lucene/Solr QA commented on LUCENE-8326: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-24 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488772#comment-16488772 ] Alessandro Benedetti commented on LUCENE-8326: -- Hi Robert, first of all thanks for your

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488345#comment-16488345 ] Robert Muir commented on LUCENE-8326: - First looking at the API change, it would be good to

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-23 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488317#comment-16488317 ] Robert Muir commented on LUCENE-8326: - Sorry, it may have been my fault. I checked "patch attached"

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-23 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487484#comment-16487484 ] Alessandro Benedetti commented on LUCENE-8326: -- It is very annoying that the patch

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-23 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487159#comment-16487159 ] Lucene/Solr QA commented on LUCENE-8326: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-22 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483879#comment-16483879 ] Alessandro Benedetti commented on LUCENE-8326: --

[jira] [Commented] (LUCENE-8326) More Like This Params Refactor

2018-05-22 Thread Alessandro Benedetti (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483880#comment-16483880 ] Alessandro Benedetti commented on LUCENE-8326: --