[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-04 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500154#comment-16500154 ] Nhat Nguyen commented on LUCENE-8335: - Thanks everyone! > Do not allow changing sof

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499812#comment-16499812 ] ASF subversion and git services commented on LUCENE-8335: - Commi

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499811#comment-16499811 ] ASF subversion and git services commented on LUCENE-8335: - Commi

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-03 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499529#comment-16499529 ] Lucene/Solr QA commented on LUCENE-8335: | (x) *{color:red}-1 overall{color}* |

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499210#comment-16499210 ] Nhat Nguyen commented on LUCENE-8335: - [~simonw] I submitted a new patch. Can you pl

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499198#comment-16499198 ] Lucene/Solr QA commented on LUCENE-8335: | (x) *{color:red}-1 overall{color}* |

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499035#comment-16499035 ] Nhat Nguyen commented on LUCENE-8335: - [~simonw] I am looking at this now. > Do not

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499021#comment-16499021 ] ASF subversion and git services commented on LUCENE-8335: - Commi

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499019#comment-16499019 ] Simon Willnauer commented on LUCENE-8335: - [~dnhatn] I had an error porting this

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499009#comment-16499009 ] ASF subversion and git services commented on LUCENE-8335: - Commi

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-02 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498978#comment-16498978 ] Simon Willnauer commented on LUCENE-8335: - [~dnhatn] this looks great I will pus

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-01 Thread Nhat Nguyen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498147#comment-16498147 ] Nhat Nguyen commented on LUCENE-8335: - [~simonw] Thanks for reviewing. I've updated

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-06-01 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497723#comment-16497723 ] Simon Willnauer commented on LUCENE-8335: - [~dnhatn] I think your patch looks go

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-05-31 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497261#comment-16497261 ] Robert Muir commented on LUCENE-8335: - as a followup, I think lets support checkinde

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-05-30 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495109#comment-16495109 ] Robert Muir commented on LUCENE-8335: - Mike, I think nearly all of your same argumen

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-05-29 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493646#comment-16493646 ] Michael McCandless commented on LUCENE-8335: [~rcmuir] do you have a use cas

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-05-28 Thread Simon Willnauer (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492483#comment-16492483 ] Simon Willnauer commented on LUCENE-8335: - > i dont think lucene needs to enforce

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-05-27 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492192#comment-16492192 ] Lucene/Solr QA commented on LUCENE-8335: | (x) *{color:red}-1 overall{color}* | \

[jira] [Commented] (LUCENE-8335) Do not allow changing soft-deletes field

2018-05-27 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491970#comment-16491970 ] Robert Muir commented on LUCENE-8335: - i dont think lucene needs to enforce this. fro