[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-13 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511879#comment-16511879 ] Jim Ferenczi commented on LUCENE-8344: -- +1 to the patch and +1 to backport to 7.4 especially if

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-13 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511547#comment-16511547 ] David Smiley commented on LUCENE-8344: -- What about [~areek] who AFAIK wrote this stuff originally?

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-13 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511445#comment-16511445 ] Adrien Grand commented on LUCENE-8344: -- FYI Jim is on vacation for a couple weeks. >

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-13 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511415#comment-16511415 ] David Smiley commented on LUCENE-8344: -- Any thoughts on this one [~jim.ferenczi]? >

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-08 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506649#comment-16506649 ] David Smiley commented on LUCENE-8344: -- The patch may be hard to review as a diff. There are 3

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503745#comment-16503745 ] ASF subversion and git services commented on LUCENE-8344: - Commit

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-06 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16503741#comment-16503741 ] ASF subversion and git services commented on LUCENE-8344: - Commit

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-05 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501717#comment-16501717 ] Michael McCandless commented on LUCENE-8344: {quote}we could simply consider the fix a

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-04 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501217#comment-16501217 ] David Smiley commented on LUCENE-8344: -- bq. Considering that re-build should be trivial in the

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-04 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500922#comment-16500922 ] Jim Ferenczi commented on LUCENE-8344: -- The exact match pass filters prefix paths that don't end

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-04 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500848#comment-16500848 ] David Smiley commented on LUCENE-8344: -- RE NRT Doc Suggester:  "This is expected" – Okay I see what

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-04 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500766#comment-16500766 ] Jim Ferenczi commented on LUCENE-8344: -- {quote}

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-04 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16500343#comment-16500343 ] David Smiley commented on LUCENE-8344: -- To demonstrate the issue in the patch I added a

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-01 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498455#comment-16498455 ] Jim Ferenczi commented on LUCENE-8344: -- I don't think a reindex is needed. With the fix we'll have

[jira] [Commented] (LUCENE-8344) TokenStreamToAutomaton doesn't ignore trailing posInc when preservePositionIncrements=false

2018-06-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498266#comment-16498266 ] David Smiley commented on LUCENE-8344: -- The patch fixes the issue and has a couple tests. It's a