[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-30 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704452#comment-16704452 ] Adrien Grand commented on LUCENE-8563: -- I created a Solr blocker issue as Jan suggested:

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-30 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704438#comment-16704438 ] ASF subversion and git services commented on LUCENE-8563: - Commit

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-29 Thread Luca Cavanna (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703382#comment-16703382 ] Luca Cavanna commented on LUCENE-8563: -- I updated the PR according to the latest comments, and

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-29 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703055#comment-16703055 ] Robert Muir commented on LUCENE-8563: - Please deprecate the crazy legacy one too, so it can be

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703007#comment-16703007 ] Adrien Grand commented on LUCENE-8563: -- My gut feeling is that this change is going to be unnoticed

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-29 Thread JIRA
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702966#comment-16702966 ] Jan Høydahl commented on LUCENE-8563: - I think it would be a far better approach to create a new

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-29 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702856#comment-16702856 ] Adrien Grand commented on LUCENE-8563: -- Thanks [~lucacavanna] this looks good to me.

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-28 Thread Luca Cavanna (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702294#comment-16702294 ] Luca Cavanna commented on LUCENE-8563: -- I opened [https://github.com/apache/lucene-solr/pull/511] . 

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread Elizabeth Haubert (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688474#comment-16688474 ] Elizabeth Haubert commented on LUCENE-8563: --- +1 if this gets us closer to BM25F. I saw the

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688455#comment-16688455 ] Michael Gibney commented on LUCENE-8563: I see; +1 as well. Seeing the main practical

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread Doug Turnbull (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688424#comment-16688424 ] Doug Turnbull commented on LUCENE-8563: --- Ah... I assumed "Adrien has his performance hat on" which

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688388#comment-16688388 ] Adrien Grand commented on LUCENE-8563: -- My goal is not to make things faster, I don't think it

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread Doug Turnbull (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688382#comment-16688382 ] Doug Turnbull commented on LUCENE-8563: --- Thanks [~jpountz] - My feeling is if Lucene has something

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688101#comment-16688101 ] Adrien Grand commented on LUCENE-8563: -- If keeping a way to get the old scores is the main concern,

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread JIRA
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688082#comment-16688082 ] Jan Høydahl commented on LUCENE-8563: - +1 to Doug's suggestion. Add the new Similarity and keep the

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-15 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687922#comment-16687922 ] Robert Muir commented on LUCENE-8563: - No, we shouldn't clutter up BM25Similarity because some users

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-14 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687440#comment-16687440 ] Michael Gibney commented on LUCENE-8563: [~jpountz], thanks for pointing out the work on BM25F.

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-14 Thread Doug Turnbull (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687268#comment-16687268 ] Doug Turnbull commented on LUCENE-8563: --- I feel perhaps one way forward is to create a second

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687260#comment-16687260 ] Adrien Grand commented on LUCENE-8563: -- bq. "assuming a single similarity" – is this something that

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-14 Thread Michael Gibney (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686877#comment-16686877 ] Michael Gibney commented on LUCENE-8563: "assuming a single similarity" -- is this something

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-14 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686633#comment-16686633 ] Adrien Grand commented on LUCENE-8563: -- That would be great [~lucacavanna]. I suspect most of the

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-14 Thread Luca Cavanna (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686370#comment-16686370 ] Luca Cavanna commented on LUCENE-8563: -- Hi folks, I would like to work on this issue. > Remove

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684107#comment-16684107 ] Adrien Grand commented on LUCENE-8563: -- Agreed [~softwaredoug] I was assuming a single similarity.

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Doug Turnbull (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684091#comment-16684091 ] Doug Turnbull commented on LUCENE-8563: --- For the sake of this discussion, here's a desmos graph

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Doug Turnbull (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684080#comment-16684080 ] Doug Turnbull commented on LUCENE-8563: --- It would modify ordering when dealing with multiple

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684051#comment-16684051 ] Adrien Grand commented on LUCENE-8563: -- bq. There will be cases where this affects relative scoring

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Elizabeth Haubert (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683976#comment-16683976 ] Elizabeth Haubert commented on LUCENE-8563: --- The boost*IDF is not particularly important, this

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683868#comment-16683868 ] Robert Muir commented on LUCENE-8563: - +1 to nuke it. Currently the explain() goes out of its way to

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683858#comment-16683858 ] Adrien Grand commented on LUCENE-8563: -- [~ehaubert] The change I'm suggesting would divide every

[jira] [Commented] (LUCENE-8563) Remove k1+1 from the numerator of BM25Similarity

2018-11-12 Thread Elizabeth Haubert (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683815#comment-16683815 ] Elizabeth Haubert commented on LUCENE-8563: --- Mathematically, it changes the ratio of