[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875621#comment-16875621 ] ASF subversion and git services commented on LUCENE-8891: - Commit

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875620#comment-16875620 ] ASF subversion and git services commented on LUCENE-8891: - Commit

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-29 Thread Gert Morten Paimla (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875553#comment-16875553 ] Gert Morten Paimla commented on LUCENE-8891: I added a new patch with the CHANGES.txt edit

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-29 Thread Lucene/Solr QA (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875438#comment-16875438 ] Lucene/Solr QA commented on LUCENE-8891: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-28 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875390#comment-16875390 ] Tomoko Uchida commented on LUCENE-8891: --- Hi [~gpaimla], I will commit the patch to the ASF repo

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-28 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875065#comment-16875065 ] Tomoko Uchida commented on LUCENE-8891: --- OK, the patch passed precommit. I'd like to wait for a

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-28 Thread Gert Morten Paimla (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875019#comment-16875019 ] Gert Morten Paimla commented on LUCENE-8891: I removed the TestEstonianStemming class and

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-28 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874965#comment-16874965 ] Tomoko Uchida commented on LUCENE-8891: --- Thanks [~gpaimla], the patch looks fine to me. I noticed

[jira] [Commented] (LUCENE-8891) Snowball stemmer/analyzer for the Estonian language

2019-06-28 Thread Tomoko Uchida (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874912#comment-16874912 ] Tomoko Uchida commented on LUCENE-8891: --- Usually Lucene uses ISO 639 Language code, so I would use