[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099432#comment-16099432
]
David Smiley commented on SOLR-10229:
-
bq. Does it make sense to use the SolrJ APIs to change the
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099057#comment-16099057
]
Erick Erickson commented on SOLR-10229:
---
Does it make sense to use the SolrJ APIs to change the
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097890#comment-16097890
]
David Smiley commented on SOLR-10229:
-
This is clearly a major step forward; thanks Erick & Amrit!
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16096085#comment-16096085
]
Amrit Sarkar commented on SOLR-10229:
-
Though I have limited exposure of writing tests in Lucene /
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080697#comment-16080697
]
Erick Erickson commented on SOLR-10229:
---
[~hossman_luc...@fucit.org] Agreed, we won't check it in
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080664#comment-16080664
]
Hoss Man commented on SOLR-10229:
-
I haven't done more then just skim the patch, but I would strongly
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16080622#comment-16080622
]
Erick Erickson commented on SOLR-10229:
---
No comments so everything's just fine, right?
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15967813#comment-15967813
]
Amrit Sarkar commented on SOLR-10229:
-
Thank you Erick for the detailed feedback,
I have rectified
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965400#comment-15965400
]
Erick Erickson commented on SOLR-10229:
---
This looks really interesting. I'll look some more
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961727#comment-15961727
]
Amrit Sarkar commented on SOLR-10229:
-
Updated patch:
Refined builder methods for the Framework.
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952316#comment-15952316
]
Erick Erickson commented on SOLR-10229:
---
bq: If you look closely at the public methods exposed to be
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952298#comment-15952298
]
Amrit Sarkar commented on SOLR-10229:
-
Thank you for the correction and the suggestions.
bq. It
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951825#comment-15951825
]
Erick Erickson commented on SOLR-10229:
---
A very minor nit, I'd drop the 's' on "withAttributes",
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937602#comment-15937602
]
David Smiley commented on SOLR-10229:
-
bq. if we're going to go to the trouble of trying to
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937420#comment-15937420
]
Erick Erickson commented on SOLR-10229:
---
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15937252#comment-15937252
]
Hoss Man commented on SOLR-10229:
-
random 2cents observation:
if we're going to go to the trouble of
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928217#comment-15928217
]
Erick Erickson commented on SOLR-10229:
---
Sounds like what I was thinking too. I _really_ don't want
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15928106#comment-15928106
]
Alexandre Rafalovitch commented on SOLR-10229:
--
Sounds good. You will also hit uniqueKey
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927875#comment-15927875
]
Amrit Sarkar commented on SOLR-10229:
-
Alexandre,
Thank you for correcting both the points out, Sorry
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927847#comment-15927847
]
Alexandre Rafalovitch commented on SOLR-10229:
--
I thought what I said and what Eric agreed
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927692#comment-15927692
]
Amrit Sarkar commented on SOLR-10229:
-
Thank you Erick for the opportunity,
Here are the key points
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925275#comment-15925275
]
Erick Erickson commented on SOLR-10229:
---
I have no objection. And you're right that if we're going
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924886#comment-15924886
]
David Smiley commented on SOLR-10229:
-
I'm really looking forward to where this is going. One
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924619#comment-15924619
]
Erick Erickson commented on SOLR-10229:
---
Assigned to myself, but Amrit is going to do the heavy
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922704#comment-15922704
]
Erick Erickson commented on SOLR-10229:
---
bq: Actually, I was not suggesting using kitchen sink as
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922677#comment-15922677
]
Alexandre Rafalovitch commented on SOLR-10229:
--
Actually, I was not suggesting using kitchen
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907881#comment-15907881
]
Erick Erickson commented on SOLR-10229:
---
Alexandre:
This is why I throw things out for discussion,
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907792#comment-15907792
]
Alexandre Rafalovitch commented on SOLR-10229:
--
What about a master schema of all field type
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907767#comment-15907767
]
Erick Erickson commented on SOLR-10229:
---
Amrit and I were chatting offline. Using the managed-schema
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896786#comment-15896786
]
Erick Erickson commented on SOLR-10229:
---
First the managed schema stuff doesn't require SolrCloud,
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896759#comment-15896759
]
David Smiley commented on SOLR-10229:
-
I whole heartedly agree that tests should try to avoid creating
[
https://issues.apache.org/jira/browse/SOLR-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15896593#comment-15896593
]
Alexandre Rafalovitch commented on SOLR-10229:
--
Could we have a master schema and then create
32 matches
Mail list logo