[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-05-01 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459993#comment-16459993 ] Erick Erickson commented on SOLR-12286: --- Uwe: I can always count on you to further my education!

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-05-01 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459524#comment-16459524 ] Uwe Schindler commented on SOLR-12286: -- Unfortunately we use slf4j, because log4j has a better

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-30 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458793#comment-16458793 ] Shawn Heisey commented on SOLR-12286: - Generally speaking, I'm all for using SLF4J parameterization

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458777#comment-16458777 ] David Smiley commented on SOLR-12286: - bq. Now maybe the right thing to do is enhance the forbidden

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-30 Thread Michael Braun (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458734#comment-16458734 ] Michael Braun commented on SOLR-12286: -- [~erickerickson] I think the int example depends also on what

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-30 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458730#comment-16458730 ] Erick Erickson commented on SOLR-12286: --- Here 's where keeping track of exactly what log message

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-30 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458706#comment-16458706 ] Erick Erickson commented on SOLR-12286: --- bq. Short lived objects are dealt with efficiently by the

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458290#comment-16458290 ] Mark Miller commented on SOLR-12286: These guys have some arguments for using parameterized logging:

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-29 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458283#comment-16458283 ] Mark Miller commented on SOLR-12286: Yeah, I think the first step here is to figure out what is going

[jira] [Commented] (SOLR-12286) Wrap log instances in "if (LOG.isLevelEnabled) { log... }

2018-04-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458280#comment-16458280 ] David Smiley commented on SOLR-12286: - I think a convincing case should be made before mandating that