[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508171#comment-16508171
]
ASF subversion and git services commented on SOLR-12361:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508160#comment-16508160
]
ASF subversion and git services commented on SOLR-12361:
Commit
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507255#comment-16507255
]
mosh commented on SOLR-12361:
-
{quote}What do you think mosh? How should I refer to you in CHANGES.txt?
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506274#comment-16506274
]
David Smiley commented on SOLR-12361:
-
New patch:
* removed overloaded
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505685#comment-16505685
]
David Smiley commented on SOLR-12361:
-
I took your PR and ran with it a bit further; patch attached.
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499819#comment-16499819
]
Cao Manh Dat commented on SOLR-12361:
-
[~dsmiley] In {{fastEstimate(map)}} and
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496048#comment-16496048
]
David Smiley commented on SOLR-12361:
-
[~caomanhdat] can you please review the changes to
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492288#comment-16492288
]
mosh commented on SOLR-12361:
-
added a new WIP pull request
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488963#comment-16488963
]
David Smiley commented on SOLR-12361:
-
BTW another thing I like about the approach of treating child
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488935#comment-16488935
]
David Smiley commented on SOLR-12361:
-
bq. Do you propose we deprecate _childDocuments for the time
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488462#comment-16488462
]
mosh commented on SOLR-12361:
-
{quote}Also, I wonder if we even need to directly "flatten" the tree to a List
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488429#comment-16488429
]
mosh commented on SOLR-12361:
-
{quote}Lets say that docs can have semantic child relations (named child
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488401#comment-16488401
]
David Smiley commented on SOLR-12361:
-
I looked closer at what it would take to remove the direct
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488384#comment-16488384
]
David Smiley commented on SOLR-12361:
-
I mostly finished reviewing #382 (removal of \_childDocuments)
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487477#comment-16487477
]
mosh commented on SOLR-12361:
-
I have just uploaded a pull request incorporating child documents as values
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483978#comment-16483978
]
David Smiley commented on SOLR-12361:
-
+1 to that
> Change _childDocuments to Map
>
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16483513#comment-16483513
]
mosh commented on SOLR-12361:
-
[~dsmiley]
Perhaps changing the _childDocuments to Map
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16482200#comment-16482200
]
mosh commented on SOLR-12361:
-
bq. Oh yeah; the multi-valued question makes this solution path more
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479953#comment-16479953
]
Lucene/Solr QA commented on SOLR-12361:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479166#comment-16479166
]
David Smiley commented on SOLR-12361:
-
Oh yeah; the multi-valued question makes this solution path
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16477455#comment-16477455
]
Lucene/Solr QA commented on SOLR-12361:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/SOLR-12361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16476952#comment-16476952
]
mosh commented on SOLR-12361:
-
quoting [~dsmiley]
{quote}One other variation on an approach is to keep the
22 matches
Mail list logo