[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-05-05 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833508#comment-16833508 ] Noble Paul commented on SOLR-13320: --- I've updated the patch to use `failOnVersionConflicts=false` and

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-05-05 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833464#comment-16833464 ] Noble Paul commented on SOLR-13320: --- yeah, the name can be misleading. even

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-05-05 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833460#comment-16833460 ] Yonik Seeley commented on SOLR-13320: - Hmmm, when I read "ignoreVersionConflicts" I assumed the wrong

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-05-04 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833165#comment-16833165 ] Tomás Fernández Löbbe commented on SOLR-13320: -- LGTM > add a param

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-05-03 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832974#comment-16832974 ] Noble Paul commented on SOLR-13320: --- I plan to commit this in a day or two > add a param

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-04-29 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829856#comment-16829856 ] Noble Paul commented on SOLR-13320: --- The version comparison logic is already handled by DUH2. Using a

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-04-29 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829853#comment-16829853 ] Tomás Fernández Löbbe commented on SOLR-13320: -- You can combine the

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-04-29 Thread Noble Paul (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829602#comment-16829602 ] Noble Paul commented on SOLR-13320: --- Modifying the payload is not always a good idea. Users usually

[jira] [Commented] (SOLR-13320) add a param ignoreVersionConflicts=true to updates to not overwrite existing docs

2019-04-29 Thread JIRA
[ https://issues.apache.org/jira/browse/SOLR-13320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829375#comment-16829375 ] Tomás Fernández Löbbe commented on SOLR-13320: -- Yes, it's not a new parameter, but my point