[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841531#comment-16841531 ] ASF subversion and git services commented on SOLR-13386: Commit

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818255#comment-16818255 ] ASF subversion and git services commented on SOLR-13386: Commit

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818252#comment-16818252 ] ASF subversion and git services commented on SOLR-13386: Commit

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818202#comment-16818202 ] Anshum Gupta commented on SOLR-13386: - Nice catch! LGTM. > Remove race in OverseerTaskQueue#remove

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818195#comment-16818195 ] Mark Miller commented on SOLR-13386: bq. I imagine this is basically impossible to write a unit test

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818191#comment-16818191 ] Mike Drob commented on SOLR-13386: -- I imagine this is basically impossible to write a unit test for?

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818178#comment-16818178 ] Mark Miller commented on SOLR-13386: Here is patch that handles NoNodeException and also prevents the

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818172#comment-16818172 ] Mark Miller commented on SOLR-13386: bq. I'll take a look. I'm hesitant to change these as part of

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16818095#comment-16818095 ] Mark Miller commented on SOLR-13386: bq. Maybe we can just skip the "exists" call? Yeah, good

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814630#comment-16814630 ] Tomás Fernández Löbbe commented on SOLR-13386: -- Good catch bq. and treat it the same as

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814624#comment-16814624 ] Mike Drob commented on SOLR-13386: -- I see similar pattern in {{ClusterProperties}} and

[jira] [Commented] (SOLR-13386) Remove race in OverseerTaskQueue#remove that can result in the Overseer causing a Zookeeper call spin spike.

[ https://issues.apache.org/jira/browse/SOLR-13386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814018#comment-16814018 ] Mark Miller commented on SOLR-13386: We just need to catch the NoNodeException setData can throw and