[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875482#comment-16875482
]
Jason Gerlowski commented on SOLR-13537:
I've merged Marcus' PR to master. I was thinking about
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875477#comment-16875477
]
ASF subversion and git services commented on SOLR-13537:
Commit
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870715#comment-16870715
]
Marcus Eagan commented on SOLR-13537:
-
Build badges won’t be dynamic in a forked repo because they
Build badges won’t be dynamic in a forked repo because they point to builds
on the Apache master branch.
For pull requests, we only need to configure web hooks in Jenkins to kick
off a build whenever a PR is opened. We cannot do that until we clean up
the tests, unfortunately. Otherwise, such an
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870695#comment-16870695
]
Jan Høydahl commented on SOLR-13537:
{quote}somebody forks the repo, commits changes to their fork,
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870012#comment-16870012
]
Shawn Heisey commented on SOLR-13537:
-
What would be really awesome would be a badge that reflects
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869929#comment-16869929
]
Marcus Eagan commented on SOLR-13537:
-
[~janhoy] Good idea Jan. I've updated the PR and added
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869924#comment-16869924
]
Jan Høydahl commented on SOLR-13537:
I'm ok with this. Just perhaps put the badges next to each other
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869799#comment-16869799
]
Jason Gerlowski commented on SOLR-13537:
I'm considering committing this next week.
The build
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865578#comment-16865578
]
Jason Gerlowski commented on SOLR-13537:
bq. If we had a way to run just plain unit tests and
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865549#comment-16865549
]
Erik Hatcher commented on SOLR-13537:
-
Fully seconded everything you said, [~gerlowskija]
Visibility
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865543#comment-16865543
]
Jason Gerlowski commented on SOLR-13537:
I want to second one thing that Jan and Shawn have
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865229#comment-16865229
]
Marcus Eagan commented on SOLR-13537:
-
[~elyograg] I was using the Solr artifact so I put it in the
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864826#comment-16864826
]
Shawn Heisey commented on SOLR-13537:
-
Does the badge reflect the build only or the build+tests?
I
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864642#comment-16864642
]
Marcus Eagan commented on SOLR-13537:
-
[~janhoy] I don't know if you saw, but I added a new badge and
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864413#comment-16864413
]
Jan Høydahl commented on SOLR-13537:
I’m not sure how useful this is? What would it mean to a casual
[
https://issues.apache.org/jira/browse/SOLR-13537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16864185#comment-16864185
]
Marcus Eagan commented on SOLR-13537:
-
I added a new screenshot to reflect how it would look in the
17 matches
Mail list logo
