[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13161726#comment-13161726
]
James Dyer commented on SOLR-2382:
--
Noble,
I have attached a patch with a corrected unit
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13160683#comment-13160683
]
Mikhail Khludnev commented on SOLR-2382:
I spawned subtask SOLR-2933
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13160688#comment-13160688
]
Noble Paul commented on SOLR-2382:
--
@James
Yes create a new issue for all the further
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159418#comment-13159418
]
Mikhail Khludnev commented on SOLR-2382:
James,
Your observation contradicts to
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158512#comment-13158512
]
James Dyer commented on SOLR-2382:
--
Mikhail,
Thank you for testing this and providing
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158623#comment-13158623
]
Mikhail Khludnev commented on SOLR-2382:
James,
Pls find my replies below
{quote}
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158797#comment-13158797
]
James Dyer commented on SOLR-2382:
--
Mikhail,
I looked at
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13158258#comment-13158258
]
Noble Paul commented on SOLR-2382:
--
@James
* My question is, Is it relevant to a large
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13154257#comment-13154257
]
James Dyer commented on SOLR-2382:
--
Noble,
I can't speak for every use case, but these
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149540#comment-13149540
]
Noble Paul commented on SOLR-2382:
--
committed svn version 121659. Thanks James
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149711#comment-13149711
]
Steven Rowe commented on SOLR-2382:
---
Hi Noble,
In {{DIHCache.java}}, you used the
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149731#comment-13149731
]
Noble Paul commented on SOLR-2382:
--
please go ahead
DIH Cache
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13149739#comment-13149739
]
Steven Rowe commented on SOLR-2382:
---
bq. please go ahead
Done: r1201784
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147072#comment-13147072
]
James Dyer commented on SOLR-2382:
--
Noble,
Is there anything else you need from me to
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13147492#comment-13147492
]
Noble Paul commented on SOLR-2382:
--
I shall commit the latest patch shortly. I'm seeing
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13137184#comment-13137184
]
James Dyer commented on SOLR-2382:
--
{quote}
The EntityProcessorBase.transformers field is
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131486#comment-13131486
]
Noble Paul commented on SOLR-2382:
--
{quote}
I realized back when this was first developed
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13131674#comment-13131674
]
James Dyer commented on SOLR-2382:
--
{quote}
The entities are reused . But it has always
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129778#comment-13129778
]
James Dyer commented on SOLR-2382:
--
Noble,
Thanks for the comments. Let me see if I can
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13129493#comment-13129493
]
Noble Paul commented on SOLR-2382:
--
A few more points
Let us avoid methods which are not
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125693#comment-13125693
]
Noble Paul commented on SOLR-2382:
--
The DIHCache interface should not have a the following
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125207#comment-13125207
]
Pulkit Singhal commented on SOLR-2382:
--
@jdyer - Awesome work!
@noble.paul - Seems
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125230#comment-13125230
]
James Dyer commented on SOLR-2382:
--
Noble,
I've been meaning to ask you if there is
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125376#comment-13125376
]
Pulkit Singhal commented on SOLR-2382:
--
James,
I'm trying to figure out how the
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1312#comment-1312
]
Noble Paul commented on SOLR-2382:
--
Sorry for the delay. i shall take it soon.
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079720#comment-13079720
]
Lance Norskog commented on SOLR-2382:
-
Thank you for this explanation!
Here is what
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079748#comment-13079748
]
Lance Norskog commented on SOLR-2382:
-
{code}
I apologize that its getting pretty
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13079761#comment-13079761
]
Lance Norskog commented on SOLR-2382:
-
One request: the DIH multi-threaded feature
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13078384#comment-13078384
]
James Dyer commented on SOLR-2382:
--
Lance,
I do not have any scientific benchmarks, but I
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073437#comment-13073437
]
Alexey Serba commented on SOLR-2382:
James, I tested your patch
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073440#comment-13073440
]
Noble Paul commented on SOLR-2382:
--
Sure
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073225#comment-13073225
]
James Dyer commented on SOLR-2382:
--
Lance,
I apologize that its getting pretty confusing.
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13073058#comment-13073058
]
Lance Norskog commented on SOLR-2382:
-
Is SOLR-2382-entities.patch/July 29, the latest
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071614#comment-13071614
]
Alexey Serba commented on SOLR-2382:
Hmm, after last Solr upgrade my application
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071616#comment-13071616
]
Noble Paul commented on SOLR-2382:
--
Hi,I shall take a look
DIH Cache Improvements
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071624#comment-13071624
]
Noble Paul commented on SOLR-2382:
--
This feature was just for debugging. Do you mean that
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071652#comment-13071652
]
Alexey Serba commented on SOLR-2382:
Yes, I'm using this feature to test if DIH
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13071970#comment-13071970
]
James Dyer commented on SOLR-2382:
--
Alexey, thanks for finding this problem and letting
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13072173#comment-13072173
]
Noble Paul commented on SOLR-2382:
--
@james it would be helpful if u can give a patch
DIH
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13069414#comment-13069414
]
Noble Paul commented on SOLR-2382:
--
SOLR-2382-solrwriter.patch is committed. see if
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068921#comment-13068921
]
Noble Paul commented on SOLR-2382:
--
@James can you please update the next patch
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068230#comment-13068230
]
Noble Paul commented on SOLR-2382:
--
@James .
Committed the first one. take a look and let
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068496#comment-13068496
]
James Dyer commented on SOLR-2382:
--
Looks good. I agree that
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13068498#comment-13068498
]
James Dyer commented on SOLR-2382:
--
DIHPropertiesWriter doesn't need to import
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13065919#comment-13065919
]
Noble Paul commented on SOLR-2382:
--
Good James. The patches look fine.I shall review it
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064503#comment-13064503
]
Steven Rowe commented on SOLR-2382:
---
bq. The patch does not apply. the codebase has
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064577#comment-13064577
]
James Dyer commented on SOLR-2382:
--
Steve,
Thanks for the tip, but I'm a bit confused
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13064606#comment-13064606
]
Steven Rowe commented on SOLR-2382:
---
James,
As you say, patches against recent checkouts
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063372#comment-13063372
]
James Dyer commented on SOLR-2382:
--
Noble,
Are you still able to work with me on this
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13063727#comment-13063727
]
Noble Paul commented on SOLR-2382:
--
my apologies for the delay.
The problem w/ the patch
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054263#comment-13054263
]
Noble Paul commented on SOLR-2382:
--
bq.cacheInit() in EntityProcessorBase specifically
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054575#comment-13054575
]
James Dyer commented on SOLR-2382:
--
{quote}
Why should the DocBuilder be even aware of
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053800#comment-13053800
]
Noble Paul commented on SOLR-2382:
--
The patch applies well.
Suggestions
The
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13054104#comment-13054104
]
James Dyer commented on SOLR-2382:
--
{quote}
The DIHCache should take the Context as a
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053090#comment-13053090
]
Noble Paul commented on SOLR-2382:
--
The patch does not apply on trunk
DIH Cache
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13053313#comment-13053313
]
James Dyer commented on SOLR-2382:
--
Noble,
I just updated to the latest and re-applied
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052394#comment-13052394
]
Noble Paul commented on SOLR-2382:
--
At least the BDB based cache will have to go to a
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052004#comment-13052004
]
James Dyer commented on SOLR-2382:
--
Noble,
I appreciate your interest in this issue! I
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13049064#comment-13049064
]
Noble Paul commented on SOLR-2382:
--
James , Does it make sense to split this issue into
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13017567#comment-13017567
]
James Dyer commented on SOLR-2382:
--
In light of the recent discussion about the Spatial
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011700#comment-13011700
]
Lance Norskog commented on SOLR-2382:
-
Have you tested this under threading?
DIH
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13011730#comment-13011730
]
James Dyer commented on SOLR-2382:
--
There is a multi-threaded unit test in
[
https://issues.apache.org/jira/browse/SOLR-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1370#comment-1370
]
Lance Norskog commented on SOLR-2382:
-
*Bravo!*
It's great to see someone else
63 matches
Mail list logo
