[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14220457#comment-14220457
]
Steven Bower commented on SOLR-3862:
Added ticket for regex based removal SOLR-6772
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973293#comment-13973293
]
Erick Erickson commented on SOLR-3862:
--
I'll add a slightly updated patch in a few. I
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973547#comment-13973547
]
Erick Erickson commented on SOLR-3862:
--
Rats! Failed to mention the JIRA in the
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13973580#comment-13973580
]
ASF subversion and git services commented on SOLR-3862:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957603#comment-13957603
]
Erick Erickson commented on SOLR-3862:
--
Don't quite know. In case you're wondering,
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13957268#comment-13957268
]
Alaknantha commented on SOLR-3862:
--
Erick: None of the existing patches support multiple
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954705#comment-13954705
]
Erick Erickson commented on SOLR-3862:
--
Just though I should add that I'm in no great
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954719#comment-13954719
]
Yonik Seeley commented on SOLR-3862:
bq. Yonik, Are you looking at the older patch?
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954721#comment-13954721
]
Alaknantha commented on SOLR-3862:
--
Erick:
Sure, I will add back the original code to
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954736#comment-13954736
]
Erick Erickson commented on SOLR-3862:
--
Hmmm, I don't have strong preferences. I'm
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954742#comment-13954742
]
Yonik Seeley commented on SOLR-3862:
bq. So let's put it back and beef up the tests.
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954853#comment-13954853
]
Erick Erickson commented on SOLR-3862:
--
Right, it would look something like this:
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954494#comment-13954494
]
Erick Erickson commented on SOLR-3862:
--
Does anyone have any objections for committing
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954526#comment-13954526
]
Erick Erickson commented on SOLR-3862:
--
[~alaknantha] Can you address Yonik's points
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13954563#comment-13954563
]
Alaknantha commented on SOLR-3862:
--
Since we are only interested in the remove
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13950696#comment-13950696
]
Alaknantha commented on SOLR-3862:
--
SOLR-3862-4.patch is the fixed patch
add remove as
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13692684#comment-13692684
]
Steven Bower commented on SOLR-3862:
This is great... I think we should change the
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13692697#comment-13692697
]
Steven Bower commented on SOLR-3862:
Actually maybe I'm understanding this feature
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13692762#comment-13692762
]
Steven Bower commented on SOLR-3862:
oh also the patch has a simple unit test now that
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13653660#comment-13653660
]
Andreas Kleiber commented on SOLR-3862:
---
I need this aswell. We have a message based
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507703#comment-13507703
]
Jim Musil commented on SOLR-3862:
-
So, I needed to hack this together to suit my needs. I'm
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13461902#comment-13461902
]
Jim Musil commented on SOLR-3862:
-
Personally, I'd like it to be remove by value. Even
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459912#comment-13459912
]
Otis Gospodnetic commented on SOLR-3862:
I *think* [~mgarski] and somebody else
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13459915#comment-13459915
]
Michael Garski commented on SOLR-3862:
--
I believe you may be thinking of someone else
[
https://issues.apache.org/jira/browse/SOLR-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13460051#comment-13460051
]
Hoss Man commented on SOLR-3862:
something to consider is the semantics: should it be
25 matches
Mail list logo