[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-12-09 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15048886#comment-15048886 ] Mark Miller commented on SOLR-8075: --- Note that this needs SOLR-8367 to be complete. > Leader Initiated

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003992#comment-15003992 ] ASF subversion and git services commented on SOLR-8075: --- Commit 1714204 from

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003997#comment-15003997 ] ASF subversion and git services commented on SOLR-8075: --- Commit 1714205 from

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002905#comment-15002905 ] Mark Miller commented on SOLR-8075: --- I'll add a little comment above checkLIR: we must check LIR before

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002875#comment-15002875 ] Mike Drob commented on SOLR-8075: - Update looks good to me. I know you expanded the comments in

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002892#comment-15002892 ] Mark Miller commented on SOLR-8075: --- It's not that it needs to happen before setLeader. The pertinent

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15002901#comment-15002901 ] Mark Miller commented on SOLR-8075: --- Also, the logic here is changed. We know do LIR prevention checks in

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003174#comment-15003174 ] Mark Miller commented on SOLR-8075: --- This node has to be the leader in the zk election line at this place

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003197#comment-15003197 ] Mark Miller commented on SOLR-8075: --- I'd file a JIRA issue to track the idea. It wouldn't be bad to

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Gregory Chanan (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003133#comment-15003133 ] Gregory Chanan commented on SOLR-8075: -- Patch looks good, thanks Mark! A comment outside the scope of

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-12 Thread Gregory Chanan (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15003209#comment-15003209 ] Gregory Chanan commented on SOLR-8075: -- bq. This node has to be the leader in the zk election line at

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000683#comment-15000683 ] Mark Miller commented on SOLR-8075: --- The latest patch also fixes LIR handling a bit. The way things

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000465#comment-15000465 ] Mark Miller commented on SOLR-8075: --- Hmm...this still needs a little tweaking I think. > Leader

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-11 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000452#comment-15000452 ] Mark Miller commented on SOLR-8075: --- Patch with fix. bq. How can I investigate / reproduce this? Don't

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-11-11 Thread Ishan Chattopadhyaya (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15000428#comment-15000428 ] Ishan Chattopadhyaya commented on SOLR-8075: How can I investigate / reproduce this? Is the

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-10-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942715#comment-14942715 ] ASF subversion and git services commented on SOLR-8075: --- Commit 1706701 from

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-10-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942712#comment-14942712 ] ASF subversion and git services commented on SOLR-8075: --- Commit 1706699 from

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-10-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942424#comment-14942424 ] Mark Miller commented on SOLR-8075: --- I'll commit this shortly. > Leader Initiated Recovery should not

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-10-03 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14942551#comment-14942551 ] Shalin Shekhar Mangar commented on SOLR-8075: - +1 LGTM > Leader Initiated Recovery should not

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-09-24 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14906959#comment-14906959 ] Mike Drob commented on SOLR-8075: - Patch LGTM. On commit, can you add a comment to

[jira] [Commented] (SOLR-8075) Leader Initiated Recovery should not stop a leader that participated in an election with all of it's replicas from becoming a valid leader.

2015-09-22 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14902551#comment-14902551 ] Mark Miller commented on SOLR-8075: --- Okay, with this patch, if the proper leader still somehow ends up in