[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15959067#comment-15959067
]
Shawn Heisey commented on SOLR-8110:
[~jens.fosh...@acando.no],
Don't put dollars signs (or any other
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958581#comment-15958581
]
Jens Foshaug commented on SOLR-8110:
Any new status on this issue? My hope is to be able to have a
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793258#comment-15793258
]
Erick Erickson commented on SOLR-8110:
--
[~hossman_luc...@fucit.org] Hoss: WDYT about putting this in
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15224104#comment-15224104
]
Henrik commented on SOLR-8110:
--
Thanks! I'll have to wait some more before upgrading, though, because I just
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15216499#comment-15216499
]
Shawn Heisey commented on SOLR-8110:
bq. Is it possible to enable support for dashes with a JVM arg (or
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15215678#comment-15215678
]
Henrik commented on SOLR-8110:
--
Upon upgrading from 5.4.0 to 5.5.0 I got this:
project-lms_shard5_replica2:
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214992#comment-15214992
]
Yago Riveiro commented on SOLR-8110:
My bad. The issue was pointed in the IRC as the actual place of
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214974#comment-15214974
]
Jason Gerlowski commented on SOLR-8110:
---
Maybe I'm missing something, but how would a
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15214325#comment-15214325
]
Yago Riveiro commented on SOLR-8110:
This enforcing shouldn't happen without an API to rename
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171096#comment-15171096
]
Jack Krupansky commented on SOLR-8110:
--
bq. "safe"... "moderate"... "legacy"
My only real nit is that
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171092#comment-15171092
]
Jack Krupansky commented on SOLR-8110:
--
bq. lucene expressions
I was going to say that Luceene
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170746#comment-15170746
]
Jan Høydahl commented on SOLR-8110:
---
I buy Yonik's arguments for reserving both dot and dash for future
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170713#comment-15170713
]
Gus Heck commented on SOLR-8110:
So perhaps a quoting Identifiers JIRA ticket that this is blocked by?
>
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170700#comment-15170700
]
Jack Krupansky commented on SOLR-8110:
--
I can't recall any explicit statement on case sensitivity,
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170698#comment-15170698
]
Jack Krupansky commented on SOLR-8110:
--
Dollar sign is permitted in Java identifier, including at the
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170689#comment-15170689
]
Shawn Heisey commented on SOLR-8110:
bq. I doubt there's a ton of people using dollar-signs in their
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170637#comment-15170637
]
Jason Gerlowski commented on SOLR-8110:
---
bq. If we expand the set to include what people may have
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170264#comment-15170264
]
Shawn Heisey commented on SOLR-8110:
Right now, the first attempts at validation (SOLR-8642) have
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170182#comment-15170182
]
Yonik Seeley commented on SOLR-8110:
bq. I've accepted the fact that Solr will probably never need to
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170155#comment-15170155
]
Jack Krupansky commented on SOLR-8110:
--
I've accepted the fact that Solr will probably never need to
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170111#comment-15170111
]
Yonik Seeley commented on SOLR-8110:
Dash is also problematic for unequivocal full support. For infix
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169830#comment-15169830
]
Jack Krupansky commented on SOLR-8110:
--
Dot is a tough case. I can see reserving it for future
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169435#comment-15169435
]
Yonik Seeley commented on SOLR-8110:
Allowing '.' in fieldnames also acts to preclude the use of '.' as
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166397#comment-15166397
]
Jason Gerlowski commented on SOLR-8110:
---
Noticed something a little odd (to me) while doing some
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159900#comment-15159900
]
Jan Høydahl commented on SOLR-8110:
---
bq. A dedicated config option might be better than
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159441#comment-15159441
]
Shawn Heisey commented on SOLR-8110:
The core characters we need are letters, numbers, and the
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159191#comment-15159191
]
Anshum Gupta commented on SOLR-8110:
I personally would prefer the more invasive approach here.
bq.
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159160#comment-15159160
]
Shawn Heisey commented on SOLR-8110:
Assuming what I outlined above is the actual approach used:
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159139#comment-15159139
]
Shawn Heisey commented on SOLR-8110:
bq. Since the concept of enforcement of naming conventions is new,
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159127#comment-15159127
]
Anshum Gupta commented on SOLR-8110:
bq. But UNDERSCORE, DASH and DOT should be supported, i.e.
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159113#comment-15159113
]
Jack Krupansky commented on SOLR-8110:
--
1. Since the concept of enforcement of naming conventions is
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158606#comment-15158606
]
Jan Høydahl commented on SOLR-8110:
---
Yep, we don't need to support all kind of strange unicode chars. But
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157475#comment-15157475
]
Anshum Gupta commented on SOLR-8110:
I am sure there would be reasons for people to use field names
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156259#comment-15156259
]
Jack Krupansky commented on SOLR-8110:
--
There is the issue of simple ASCII letters vs. Unicode
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15156250#comment-15156250
]
Jason Gerlowski commented on SOLR-8110:
---
1.) Sounds like (aside from a few comments about the
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151121#comment-15151121
]
Jack Krupansky commented on SOLR-8110:
--
It would be nice to say that a "Solr identifier" had the same
IMO, simply having a standard at least gives us a standard and a reason to
fix the edge cases. As it stands now, there's no basis to even say
something should be fixed. So periods are fine as far as I'm concerned.
On Feb 17, 2016 10:49, "Shawn Heisey (JIRA)" wrote:
>
> [
>
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149605#comment-15149605
]
Shawn Heisey commented on SOLR-8110:
With the caveat that I haven't actually tried it and haven't
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148954#comment-15148954
]
Jason Gerlowski commented on SOLR-8110:
---
Personally, I'd be fine with allowing field names to contain
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148921#comment-15148921
]
Gus Heck commented on SOLR-8110:
Disallowing the '.' character in field names will be difficult for one
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148692#comment-15148692
]
Jason Gerlowski commented on SOLR-8110:
---
Anyone object to my starting on this? Thinking of putting
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132455#comment-15132455
]
Shawn Heisey commented on SOLR-8110:
I think we should enforce restrictions on all identifiers, not
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939513#comment-14939513
]
Alan Woodward commented on SOLR-8110:
-
+1
We should log a warning for each dodgy fieldname in
[
https://issues.apache.org/jira/browse/SOLR-8110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938973#comment-14938973
]
Hoss Man commented on SOLR-8110:
As far as the "how" to implement this, i think it would be pretty straight
44 matches
Mail list logo