[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-02-02 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127988#comment-15127988 ] ASF subversion and git services commented on SOLR-8508: --- Commit edf66

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-02-01 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127050#comment-15127050 ] ASF subversion and git services commented on SOLR-8508: --- Commit edf66

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-02-01 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126998#comment-15126998 ] Joel Bernstein commented on SOLR-8508: -- After reviewing the patch I like how you handl

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-02-01 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126920#comment-15126920 ] Joel Bernstein commented on SOLR-8508: -- I plan on looking at this later today. I may m

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-02-01 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126696#comment-15126696 ] Kevin Risden commented on SOLR-8508: [~joel.bernstein] - Any more comments on this patc

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-30 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124902#comment-15124902 ] Joel Bernstein commented on SOLR-8508: -- Actually the statement still has access to the

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-29 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124436#comment-15124436 ] Joel Bernstein commented on SOLR-8508: -- I think we'll need to keep the SolrStream hand

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-29 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124388#comment-15124388 ] Kevin Risden commented on SOLR-8508: {quote} 1) Why move the SolrStream handling to the

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-29 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124383#comment-15124383 ] Joel Bernstein commented on SOLR-8508: -- Patch looks good. I like that it uses SQL to g

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-29 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123776#comment-15123776 ] Joel Bernstein commented on SOLR-8508: -- But we can push these types of decisions down

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-29 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123765#comment-15123765 ] Joel Bernstein commented on SOLR-8508: -- This could work as well. In the early stages i

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-29 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123724#comment-15123724 ] Kevin Risden commented on SOLR-8508: What makes more sense to me is: select a from zkJ

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-27 Thread Joel Bernstein (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120068#comment-15120068 ] Joel Bernstein commented on SOLR-8508: -- I think the best approach is to sublcass State

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-07 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088024#comment-15088024 ] Kevin Risden commented on SOLR-8508: Need to figure out best way to return a java.sql.R

[jira] [Commented] (SOLR-8508) Implement DatabaseMetaDataImpl.getCatalogs()

2016-01-07 Thread Kevin Risden (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087965#comment-15087965 ] Kevin Risden commented on SOLR-8508: Requires SOLR-8503 to be merged first. > Implemen