[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787153#comment-16787153
]
Christine Poerschke commented on SOLR-8599:
---
bq. ... maybe fix it in another Jira ...
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16236750#comment-16236750
]
Varun Thacker commented on SOLR-8599:
-
Hi Dennis,
In ConnectionManager do we intend to wait for 1 or 5
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252955#comment-15252955
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252953#comment-15252953
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252868#comment-15252868
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252867#comment-15252867
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252863#comment-15252863
]
Anshum Gupta commented on SOLR-8599:
Thanks Keith. We need to track these better :)
I'll commit the
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252815#comment-15252815
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252814#comment-15252814
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15252720#comment-15252720
]
Keith Laban commented on SOLR-8599:
---
[~anshumg] There were two separate commits for this ticket, but they
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203380#comment-15203380
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158520#comment-15158520
]
Uwe Schindler commented on SOLR-8599:
-
Ah, the whole test is marked as slow.
> Errors in construction
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158511#comment-15158511
]
Uwe Schindler commented on SOLR-8599:
-
2nd: Do we really need to wait 5 !!! seconds in this test? This
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158506#comment-15158506
]
Uwe Schindler commented on SOLR-8599:
-
Hi, I would go a completely other route to test this:
- make the
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158473#comment-15158473
]
Uwe Schindler commented on SOLR-8599:
-
In addition there is a bug in the test: It sets the "correct"
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158459#comment-15158459
]
Uwe Schindler commented on SOLR-8599:
-
Hi,
why not make the setter of the zkAddress package private?
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158017#comment-15158017
]
Dennis Gove commented on SOLR-8599:
---
Thanks. I'll keep that in mind going forward - and I agree,
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158011#comment-15158011
]
ASF subversion and git services commented on SOLR-8599:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157834#comment-15157834
]
Uwe Schindler commented on SOLR-8599:
-
Hi,
please don't write tests that rely on DNS failures. Every
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157810#comment-15157810
]
Mark Miller commented on SOLR-8599:
---
Yeah, we try to avoid that in tests due to dns hijacking. I think
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157644#comment-15157644
]
Dennis Gove commented on SOLR-8599:
---
I have somewhat of an interesting situation at hand here.
As part
[
https://issues.apache.org/jira/browse/SOLR-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15141360#comment-15141360
]
Dennis Gove commented on SOLR-8599:
---
This fais the forbidden api precommit check.
{code}
[forbidden-apis]
22 matches
Mail list logo