[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121667#comment-15121667
]
Joel Bernstein commented on SOLR-8602:
--
I think the error handling in ResultSetImpl constructor is
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121784#comment-15121784
]
ASF subversion and git services commented on SOLR-8602:
---
Commit
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121754#comment-15121754
]
Joel Bernstein commented on SOLR-8602:
--
Currently the result set tests are only testing queries with a
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121365#comment-15121365
]
Joel Bernstein commented on SOLR-8602:
--
I was just reviewing the exception handling in ResultSetImpl
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121375#comment-15121375
]
Joel Bernstein commented on SOLR-8602:
--
Doing some more review. That particular exception would have
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121417#comment-15121417
]
Kevin Risden commented on SOLR-8602:
The issue was that there was no exception added to the
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121356#comment-15121356
]
Joel Bernstein commented on SOLR-8602:
--
There are lot's of inconsistencies between limited and
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121460#comment-15121460
]
Joel Bernstein commented on SOLR-8602:
--
What was the change in this patch?
> Implement
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121497#comment-15121497
]
Kevin Risden commented on SOLR-8602:
H guess I had changed it already. I also consolidated the
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121492#comment-15121492
]
Kevin Risden commented on SOLR-8602:
For reference, on MySQL "select id, bad from test" results in an
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121468#comment-15121468
]
Kevin Risden commented on SOLR-8602:
changed new RuntimeException(MESSAGE) to new
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121489#comment-15121489
]
Joel Bernstein commented on SOLR-8602:
--
The code I was reviewing already was doing that in the
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121563#comment-15121563
]
Joel Bernstein commented on SOLR-8602:
--
Ok, I'll review.
> Implement ResultSetImpl.wasNull()
>
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15121776#comment-15121776
]
Joel Bernstein commented on SOLR-8602:
--
Planning on committing this shortly.
> Implement
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120391#comment-15120391
]
Joel Bernstein commented on SOLR-8602:
--
Latest patch is looking good.
> Implement
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120582#comment-15120582
]
Joel Bernstein commented on SOLR-8602:
--
Alright I found the bug. I'll work with your latest patch and
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120491#comment-15120491
]
Kevin Risden commented on SOLR-8602:
sounds good to me. The last attached patch 21KB ~6pm works
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120526#comment-15120526
]
Joel Bernstein commented on SOLR-8602:
--
>From what I can see the meta data Tuple should work OK in
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120447#comment-15120447
]
Kevin Risden commented on SOLR-8602:
I want to add a few more test cases:
* testing with facet instead
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120467#comment-15120467
]
Joel Bernstein commented on SOLR-8602:
--
If we want to see how the /export handler behaves in the test
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120561#comment-15120561
]
Joel Bernstein commented on SOLR-8602:
--
This was on a simple select no limit?
> Implement
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120578#comment-15120578
]
Joel Bernstein commented on SOLR-8602:
--
I've got it reproducing. I'll figure out what the problem is.
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120505#comment-15120505
]
Kevin Risden commented on SOLR-8602:
Created SOLR-8608 and linked appropriate JIRAs.
> Implement
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120429#comment-15120429
]
Joel Bernstein commented on SOLR-8602:
--
I believe in the case of the /export handler numerics will
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120482#comment-15120482
]
Joel Bernstein commented on SOLR-8602:
--
Ok, I'll work with the new patch.
The facet / map_reduce flag
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120522#comment-15120522
]
Joel Bernstein commented on SOLR-8602:
--
I'm not in a hurry. Let me know if you want me to take a look.
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120568#comment-15120568
]
Joel Bernstein commented on SOLR-8602:
--
I'll take you're last patch and change numWorkers=2 and see
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120565#comment-15120565
]
Joel Bernstein commented on SOLR-8602:
--
Weird from a code review I don't see how you would be getting
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120719#comment-15120719
]
Kevin Risden commented on SOLR-8602:
It looks good except that lines 372 and 373 are commented out.
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120608#comment-15120608
]
Joel Bernstein commented on SOLR-8602:
--
[~risdenk], let me know if you want to work some with this
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120721#comment-15120721
]
Kevin Risden commented on SOLR-8602:
If this is a valid SQL statement then it needs to work for both
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120480#comment-15120480
]
Kevin Risden commented on SOLR-8602:
Looks like with aggregationMode=map_reduce and workers=2 then
[
https://issues.apache.org/jira/browse/SOLR-8602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15120559#comment-15120559
]
Joel Bernstein commented on SOLR-8602:
--
This sounds like a you've found a bug. The SQLHandler should
33 matches
Mail list logo
