[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-22 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158216#comment-15158216 ] Mark Miller commented on SOLR-8696: --- I think we should break up these two changes. Can we fix the nasty

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-22 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157991#comment-15157991 ] Mark Miller commented on SOLR-8696: --- The history of legacy mode: Initially, we had no collections API.

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155890#comment-15155890 ] Mark Miller commented on SOLR-8696: --- addReplica calls create core on a node. When a core is created, it

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155888#comment-15155888 ] Scott Blum commented on SOLR-8696: -- [~markrmil...@gmail.com] Yes, I get the breakpoint in

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155817#comment-15155817 ] Mark Miller commented on SOLR-8696: --- I'd love to get legacy mode out for 6, but I doubt I'll have the

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155815#comment-15155815 ] Mark Miller commented on SOLR-8696: --- bq. SliceMutator.addReplica Ah, got you sorry, check out:

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155773#comment-15155773 ] Mark Miller commented on SOLR-8696: --- bq. The only local changes I have are to comment out the calls to

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155772#comment-15155772 ] Mark Miller commented on SOLR-8696: --- I was on recent master at the time. I'll replicate and report steps

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-20 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155750#comment-15155750 ] Scott Blum commented on SOLR-8696: -- What git sha are you on? I'm absolutely not hitting that break point

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-19 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15155214#comment-15155214 ] Mark Miller commented on SOLR-8696: --- bq. But I'm not getting a hit. What gives? I'm confused. Does that

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-19 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154744#comment-15154744 ] Mark Miller commented on SOLR-8696: --- I made a run at removing legacyMode before the 6 release, but while

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153460#comment-15153460 ] Scott Blum commented on SOLR-8696: -- Okay, I can't figure this out after digging for quite a while. I need

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153321#comment-15153321 ] Shalin Shekhar Mangar commented on SOLR-8696: - Yeah but that only happens for clusters

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153309#comment-15153309 ] Scott Blum commented on SOLR-8696: -- [~shalinmangar] Am I crazy or doesn't the call to

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153270#comment-15153270 ] Shalin Shekhar Mangar commented on SOLR-8696: - That'd be great, thanks! > Optimize overseer +

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153267#comment-15153267 ] Scott Blum commented on SOLR-8696: -- Great! Would you like me to include a fix for ADDREPLICA in this

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Shalin Shekhar Mangar (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153226#comment-15153226 ] Shalin Shekhar Mangar commented on SOLR-8696: - Thanks Scott. The ZkStateReader refresh is a

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153164#comment-15153164 ] Scott Blum commented on SOLR-8696: -- Actually on second thought, to become the new Overseer, you would have

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Scott Blum (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153041#comment-15153041 ] Scott Blum commented on SOLR-8696: -- bq. It keeps itself up to date, but with some delay. Are we sure we

[jira] [Commented] (SOLR-8696) Optimize overseer + startup

2016-02-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15153015#comment-15153015 ] Mark Miller commented on SOLR-8696: --- In one of the leader election improvement patches, I think I took