[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355192#comment-15355192 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355191#comment-15355191 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323263#comment-15323263 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323244#comment-15323244 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323222#comment-15323222 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323211#comment-15323211 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15323149#comment-15323149 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322987#comment-15322987 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15322010#comment-15322010 ] Scott Blum commented on SOLR-9191: -- Oh, sorry! I think it's because I force-pushed my branch after

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321898#comment-15321898 ] David Smiley commented on SOLR-9191: FYI the ASF git/jira commit bot sends updates to all JIRA issues

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321891#comment-15321891 ] ASF GitHub Bot commented on SOLR-9191: -- Github user asfgit closed the pull request at:

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321890#comment-15321890 ] Scott Blum commented on SOLR-9191: -- I went ahead and committed to master to unblock [~noble.paul]. >

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321888#comment-15321888 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321889#comment-15321889 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15321114#comment-15321114 ] Scott Blum commented on SOLR-9191: -- Cool. Any other feedback beyond the Predicate change?

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320029#comment-15320029 ] Noble Paul commented on SOLR-9191: -- I'm changing it as well > OverseerTaskQueue.peekTopN() fatally flawed

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320027#comment-15320027 ] Scott Blum commented on SOLR-9191: -- Yeah, I was going to use Predicate, but wanted to be compatible with

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15320017#comment-15320017 ] Noble Paul commented on SOLR-9191: -- {{DistributedQueue.peekElements(int n, long waitMillis,

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319896#comment-15319896 ] ASF GitHub Bot commented on SOLR-9191: -- Github user dragonsinth commented on the issue:

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319717#comment-15319717 ] ASF GitHub Bot commented on SOLR-9191: -- Github user dragonsinth commented on a diff in the pull

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319716#comment-15319716 ] ASF GitHub Bot commented on SOLR-9191: -- Github user dragonsinth commented on a diff in the pull

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319700#comment-15319700 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319701#comment-15319701 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319597#comment-15319597 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319554#comment-15319554 ] Scott Blum commented on SOLR-9191: -- Good idea, will do. Working on getting tests to pass globally atm. >

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319546#comment-15319546 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319508#comment-15319508 ] Mark Miller commented on SOLR-9191: --- Can we expand a test to catch this more easily? >

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319445#comment-15319445 ] Scott Blum commented on SOLR-9191: -- [~markrmil...@gmail.com] you might be interested in this one >

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319429#comment-15319429 ] Scott Blum commented on SOLR-9191: -- [~noble.paul] some rework from the inital patch: Java 8isms for

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319425#comment-15319425 ] ASF GitHub Bot commented on SOLR-9191: -- GitHub user dragonsinth opened a pull request:

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319419#comment-15319419 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319417#comment-15319417 ] ASF subversion and git services commented on SOLR-9191: --- Commit

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15319280#comment-15319280 ] Scott Blum commented on SOLR-9191: -- And feedback on this? It impacts overseer pretty badly. >

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318792#comment-15318792 ] Scott Blum commented on SOLR-9191: -- Here's my suggested patch, which I'll need to port to master, 6x, 5x:

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318785#comment-15318785 ] Scott Blum commented on SOLR-9191: -- No, you can only 'getChildren' en masse >

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318782#comment-15318782 ] Noble Paul commented on SOLR-9191: -- Is there a way we can avoid reading the "already read" items from ZK?

[jira] [Commented] (SOLR-9191) OverseerTaskQueue.peekTopN() fatally flawed

[ https://issues.apache.org/jira/browse/SOLR-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15318363#comment-15318363 ] Noble Paul commented on SOLR-9191: -- does ZK have any way to read items 'newer' than some id ? >