[ https://issues.apache.org/jira/browse/LUCENE-3712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-3712. ----------------------------------- Resolution: Fixed Committed trunk revision: 1235228 Committed 3.x revision: 1235234 > Remove unused (and untested) methods from ReaderUtil that are also veeeeery > ineffective > --------------------------------------------------------------------------------------- > > Key: LUCENE-3712 > URL: https://issues.apache.org/jira/browse/LUCENE-3712 > Project: Lucene - Java > Issue Type: Task > Components: core/other > Affects Versions: 3.5 > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: 3.6, 4.0 > > Attachments: LUCENE-3712.patch > > > ReaderUtil contains two methods that are nowhere used and not even tested. > Additionally those are implemented with useless List->array copying; > ineffective docStart calculation for a binary search later instead directly > returning the reader while scanning -- and I am not sure if they really work > as expected. As ReaderUtil is @lucene.internal we should remove them in 3.x > and trunk, alternatively the useless array copy / docStarts handling should > be removed and tests added: > {code:java} > public static IndexReader subReader(int doc, IndexReader reader) > public static IndexReader subReader(IndexReader reader, int subIndex) > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org