[ https://issues.apache.org/jira/browse/LUCENE-4248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-4248. --------------------------------- Resolution: Fixed Fix Version/s: 5.0 4.0 > Producers to the Codec API don't always follow the spec > ------------------------------------------------------- > > Key: LUCENE-4248 > URL: https://issues.apache.org/jira/browse/LUCENE-4248 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Fix For: 4.0, 5.0 > > Attachments: LUCENE-4248.patch, LUCENE-4248.patch, LUCENE-4248.patch, > LUCENE-4248.patch > > > We added AssertingCodec etc and have lots of tests that consumers of the > codec api follow a strict set of rules: but nothing checks the producers > feeding these apis (IndexWriter, codec merge implementations, etc). > We should beef up AssertingCodec to validate these things: this way the API > is being followed. > Simple examples of things include checking that producers are feeding terms > to the consumers consistent with their comparator, that they aren't providing > bogus or out of band statistics, and that they are invoking the right methods > consistently (e.g. not forgetting to call finishDoc or something that might > confuse someones codec). > This is also nice since now we have quite a few tests (TestCodecs, > TestPostingsFormat, etc) that feed these APIs directly, it could find some > test bugs. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org