[
https://issues.apache.org/jira/browse/LUCENE-5148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand resolved LUCENE-5148.
----------------------------------
Resolution: Won't Fix
bq. The patch seems to have a very large amount of changes for such a small
thing... is there some reformatting happening?
Yes. In some cases I couldn't use anonymous classes to implement clone properly
so I had to use named classes for the codec-specific SortedSet impls so the
indentation was smaller by 2 spaces.
bq. If we can't implement this without major changes: then I dont think we
should do it.
I wanted to know your opinion first but I came to a similar conclusion. I
initially hadn't thought about the issue of cloning too many index inputs...
Thanks for your input!
> SortedSetDocValues caching / state
> ----------------------------------
>
> Key: LUCENE-5148
> URL: https://issues.apache.org/jira/browse/LUCENE-5148
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-5148.patch
>
>
> I just spent some time digging into a bug which was due to the fact that
> SORTED_SET doc values are stateful (setDocument/nextOrd) and are cached per
> thread. So if you try to get two instances from the same field in the same
> thread, you will actually get the same instance and won't be able to iterate
> over ords of two documents in parallel.
> This is not necessarily a bug, this behavior can be documented, but I think
> it would be nice if the API could prevent from such mistakes by storing the
> state in a separate object or cloning the SortedSetDocValues object in
> SegmentCoreReaders.getSortedSetDocValues?
> What do you think?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
