[
https://issues.apache.org/jira/browse/SOLR-9839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-9839.
-----------------------------
Resolution: Won't Fix
For future reference, there are ~175 invocations of System.clearProperty across
the various Solr tests that we might be able to get rid of and rely completely
on the restore rule. I'm not in favor of that solution, since it makes it very
non-intuitive to understand what is going on, but it is worth considering if
somebody ever attempts to do other clean up in the tests.
> Use 'useFactory' in tests instead of setting manually
> -----------------------------------------------------
>
> Key: SOLR-9839
> URL: https://issues.apache.org/jira/browse/SOLR-9839
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: Mike Drob
> Priority: Minor
> Attachments: SOLR-9839.patch
>
>
> We have several tests that will explicitly set a directory factory via
> SysProp, some of which forget to unset it.
> We should use {{useFactory}} so that we can benefit from the call to
> {{resetFactory}} in {{SolrTestCaseJ4.teardownTestCases}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
