[ https://issues.apache.org/jira/browse/LUCENE-3605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael McCandless updated LUCENE-3605: --------------------------------------- Attachment: LUCENE-3605.patch Patch: I removed the sleep+retry loop in loading the segments.gen file; I don't think SIS should do any sleeping (it's risky; an app could in theory hit the net 0.5 second sleep here). I also changed SegmentInfos.finishCommit to sync this file, if it was written successfully, but to suppress exceptions (but then try to delete the file) since a reader could have it open as we try to commit (which is fine; the file is optional since we use dir listing to locate segments_N). > revisit segments.gen sleeping > ----------------------------- > > Key: LUCENE-3605 > URL: https://issues.apache.org/jira/browse/LUCENE-3605 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Robert Muir > Assignee: Michael McCandless > Attachments: LUCENE-3605.patch > > > in LUCENE-3601, i worked up a change where we intentionally crash() all > un-fsynced files > in tests to ensure that we are calling sync on files when we should. > I think this would be nice to do always (and with some fixes all tests pass). > But this is super-slow sometimes because when we corrupt the unsynced > segments.gen, it causes > SIS.read to take 500ms each time (and in checkindex for some reason we do > this twice, which seems wrong). > I can workaround this for now for tests (just do a partial crash that avoids > corrupting the segments.gen), > but I wanted to create this issue for discussion about the > sleeping/non-fsyncing of segments.gen, just > because i guess its possible someone could hit this slowness. > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org