[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4132:
---
Attachment: LUCENE-4132.patch
Patch removes Cloenable from LiveIWC. Now only IWC is Cloenable.
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4132:
---
Attachment: LUCENE-4132.patch
Sorry if it came across like that, but I don't mean to rush or shove
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4132:
---
Attachment: LUCENE-4132.patch
Thanks Uwe. The test is now fixed by saving all 'synthetic' methods
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4132:
---
Attachment: LUCENE-4132.patch
bq. Can we override all methods so the javadocs aren't confusing.
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4132:
---
Attachment: LUCENE-4132.patch
Good catch Mike ! It went away in the last changes. I re-added
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4132:
---
Attachment: LUCENE-4132.patch
Patch removes ReadOnlyConfig and the tests from TestIWC that ensure
[
https://issues.apache.org/jira/browse/LUCENE-4132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4132:
---
Attachment: LUCENE-4132.patch
Phew, that was tricky, but here's the end result -- refactored
