[ 
https://issues.apache.org/jira/browse/SOLR-10756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steve Rowe updated SOLR-10756:
------------------------------
    Attachment: SOLR-10756.patch

Patch implementing [~shalinmangar]'s suggestions: undeprecating 
{{ZkStateReader.updateClusterState()}}, marking it as @lucene.internal, 
renaming it to
 {{forciblyRefreshAllClusterStateSlow()}}, and converting the single test usage 
to {{forceUpdateCollection()}}.

Committing shortly.


> deal with (deprecated but still used) ZkStateReader.updateClusterState()
> ------------------------------------------------------------------------
>
>                 Key: SOLR-10756
>                 URL: https://issues.apache.org/jira/browse/SOLR-10756
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Hoss Man
>            Assignee: Steve Rowe
>            Priority: Blocker
>             Fix For: 7.0
>
>         Attachments: SOLR-10756.patch
>
>
> spinning off of SOLR-10755...
> * ZkStateReader
> ** deprecated updateClusterState() is Still used by Overseer
> *** is the Overseer usage a mistake? should Overseer be doing something else?
> ** no obviously easy way to refactor this method it into Overseer w/o making 
> several private ZkStateReader methods public
> ** if Overseer usage is "ok" perhaps we should just rename this method 
> something more dangerous sounding and mark lucene.internal ?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to