[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904729#action_12904729
]
Michael McCandless commented on LUCENE-2590:
Patch looks great Simon, thanks!
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904751#action_12904751
]
Michael McCandless commented on LUCENE-2590:
Thank you!
I think we should
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904753#action_12904753
]
Simon Willnauer commented on LUCENE-2590:
-
bq. I think we should also backport to
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904250#action_12904250
]
Michael McCandless commented on LUCENE-2590:
Looks great!
Though, can't BS
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904313#action_12904313
]
Simon Willnauer commented on LUCENE-2590:
-
bq. Though, can't BS and BS2 just call
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903952#action_12903952
]
Michael McCandless commented on LUCENE-2590:
{quote}
One way of doing it would
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12902379#action_12902379
]
Simon Willnauer commented on LUCENE-2590:
-
bq. Oh I see we can't quite have Scorer
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901843#action_12901843
]
Michael McCandless commented on LUCENE-2590:
Patch looks good! Thanks, Simon.
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901344#action_12901344
]
Michael McCandless commented on LUCENE-2590:
I think the API changes are too
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898854#action_12898854
]
Michael McCandless commented on LUCENE-2590:
OK I like the 3 methods instead
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12899000#action_12899000
]
Simon Willnauer commented on LUCENE-2590:
-
{quote}
The heavy generics would be
[
https://issues.apache.org/jira/browse/LUCENE-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12898638#action_12898638
]
Simon Willnauer commented on LUCENE-2590:
-
Mike, eventually we are getting this
12 matches
Mail list logo