[jira] [Commented] (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-09-07 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098919#comment-13098919 ] Erik Hatcher commented on LUCENE-2945: -- Committed patch to trunk. Slight modified -

[jira] [Commented] (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-09-07 Thread Erik Hatcher (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098882#comment-13098882 ] Erik Hatcher commented on LUCENE-2945: -- The current patch is for trunk only. I'll g

[jira] [Commented] (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-08-09 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081910#comment-13081910 ] Paul Elschot commented on LUCENE-2945: -- I noticed the local conflict when the move w

[jira] [Commented] (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-08-09 Thread Simon Rosenthal (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081893#comment-13081893 ] Simon Rosenthal commented on LUCENE-2945: - Paul - can you refactor the 2945d patc

[jira] [Commented] (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-05-02 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027755#comment-13027755 ] Paul Elschot commented on LUCENE-2945: -- Does the latest patch solve the original pro

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-09 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004714#comment-13004714 ] Paul Elschot commented on LUCENE-2945: -- bq. The Query class already is cloneable so

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-09 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004655#comment-13004655 ] Grant Ingersoll commented on LUCENE-2945: - The Query class already is cloneable s

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-09 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13004646#comment-13004646 ] Paul Elschot commented on LUCENE-2945: -- As to the patch of 5 March, QueryUtils uses

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-02 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001596#comment-13001596 ] Grant Ingersoll commented on LUCENE-2945: - bq. but there is no test added for the

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-02 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001593#comment-13001593 ] Paul Elschot commented on LUCENE-2945: -- Grant, could you review the patch? > Surrou

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-02 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001495#comment-13001495 ] Paul Elschot commented on LUCENE-2945: -- Ok, I forgot that inner classes can use the

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-02 Thread Grant Ingersoll (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001485#comment-13001485 ] Grant Ingersoll commented on LUCENE-2945: - What about the anonymous inner classes

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-02 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001331#comment-13001331 ] Paul Elschot commented on LUCENE-2945: -- A quick fix would be to implement hashCode()

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-01 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001137#comment-13001137 ] Paul Elschot commented on LUCENE-2945: -- It turns out that 14 or 15 classes in o.a.l.

[jira] Commented: (LUCENE-2945) Surround Query doesn't properly handle equals/hashcode

2011-03-01 Thread Paul Elschot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001049#comment-13001049 ] Paul Elschot commented on LUCENE-2945: -- This one is in the category oversights that