DocBuilder Inefficiency
-----------------------

                 Key: SOLR-1927
                 URL: https://issues.apache.org/jira/browse/SOLR-1927
             Project: Solr
          Issue Type: Improvement
    Affects Versions: 1.4
            Reporter: Robert Zotter
            Priority: Trivial


I am looking into collectDelta method in DocBuilder.java and I noticed that
to determine the deltaRemoveSet it currently loops through the whole
deltaSet for each deleted row. (Version 1.4.0 line 641)

Does anyone else agree with the fact that this is quite inefficient?

For delta-imports with a large deltaSet and deletedSet I found a
considerable improvement in speed if we just save all deleted keys in a set.
Then we just have to loop through the deltaSet once to determine which rows
should be removed by checking if the deleted key set contains the delta row
key.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to