Thanks for chiming in guys. I created a JIRA for this (SOLR-13775).
Haven't really thought about wording or anything yet, if either of you
have any suggestions. Otherwise I'll hope to get to this over the
weekend.
Jason
On Tue, Sep 17, 2019 at 3:39 PM David Smiley wrote:
>
> RE the idea of
RE the idea of shash-merge from a PR: that would be cool were it not for
CHANGES.txt; ah well.
+1 to "put it in the PR template checklist"
~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley
On Tue, Sep 17, 2019 at 2:37 PM Jan Høydahl wrote:
> I like
I like the idea to put it in the PR template checklist. Or you can ask the
contributor to check that box. I once made a PR against another PR branch and
it worked but was too many steps.
I like the idea of squash-merging from PR branch since (I believe) the commit
will then have the credit of
Github does have an option that fork-owners can click when they create
a PR that will give those with karma on the upstream repo the same
karma on their PR branch. [1] That would solve this problem somewhat.
But it's still up to users to choose that themselves. Maybe it makes
sense to mention
Hey all,
I've hit a small snag reviewing a few PRs on github recently. Wanted
to see if anyone has any suggestions for my workflow:
I’ve found myself in the position a few times where I want to add a
few small changes to a contributor’s PR…either to help them with a
piece they haven’t gotten to
