Re: How do we interpret replicationFactor ?

2018-06-15 Thread Varun Thacker
If someone has 5 minutes could they please review my approach taken in SOLR-11676 On Fri, Jun 15, 2018 at 12:24 PM, Varun Thacker wrote: > Thanks Tomás > > The approach I'm taking is SolrJ never sets replicationFactor and keep > back-compat for older clients who would set both replicationFactor

Re: How do we interpret replicationFactor ?

2018-06-15 Thread Varun Thacker
Thanks Tomás The approach I'm taking is SolrJ never sets replicationFactor and keep back-compat for older clients who would set both replicationFactor and nrtReplicas for the same thing I'm not going to remove it from cluster state just yet ( even with keeping back-compat ) . I'm thinking this pa

Re: How do we interpret replicationFactor ?

2018-06-15 Thread Tomás Fernández Löbbe
I think we should deprecate it. There were some concerns about this because new users would understand quickly what "replicationFactor" is, while "nrtReplicas" is not so intuitive, but I don't like having two ways to do the same, and now that there are multiple types of replicas I think it's better

How do we interpret replicationFactor ?

2018-06-14 Thread Varun Thacker
While working on SOLR-11676 a few questions came that were't obvious Should a user be allowed to specify replicationFactor and nrtReplicas ? Today it's possible but my answer was it shouldn't be. What do others think? If everyone agrees the two s