Re: PeerSync.java: why "completeList" in handleVersions()?

2016-02-26 Thread Ramsey Haddad
My co-worker, Christine Poerschke, pointed out that the "completeList" term was added in a change described as "restore old deletes via tlog so peersync won't reorder". If the goal was only the replay of deletes older than ourLowThreshold, then keeping that goal doesn't need to interfere with the

PeerSync.java: why "completeList" in handleVersions()?

2016-02-25 Thread Ramsey Haddad
Does "!completeList" do anything necessary in the line: if (!completeList && Math.abs(otherVersion) < ourLowThreshold) break; I think the line should simply be: if (Math.abs(otherVersion) < ourLowThreshold) break; - The inclusion of "!completeList" in this conditional would seem to only cau