Thanks for reviewing this Adrien.
I think your proposal works very well for what I wanted to do. I chose to
move the DelegatingCacheHelper under FilterDirectoryReader, it
seemed simpler and one less public class, but I'm happy to introduce
the new LastingFilterDirectoryReader subclass if that's mo
Hi Nikola,
I've been striving to keep the CacheKey constructor private in order
to avoid performance bugs with reader wrappers that only exist for the
lifetime of a single request, so I appreciate that you are thinking of
options that guide users towards only creating custom cache keys on
long-liv
Continuing down the path of modularizing Elasticsearch we are down to the
last hurdle to eliminate Lucene split packages from the codebase
- LazySoftDeletesDirectoryReaderWrapper [1]. This class is a version of
Lucene's SoftDeletesDirectoryReaderWrapper [2], but very specific to
Elasticsearch's use