Re: Using util.Optional instead of a raw null?

2019-04-24 Thread Gus Heck
I'm not so keen on using optional for parameters (-0). It's really for return values. I tend to agree with this SO answer: https://stackoverflow.com/a/31923105 YMMV On Fri, Apr 19, 2019 at 12:43 AM Tomás Fernández Löbbe < tomasflo...@gmail.com> wrote: > In general, I'm +1. I think we may want to

Re: Using util.Optional instead of a raw null?

2019-04-18 Thread Tomás Fernández Löbbe
In general, I'm +1. I think we may want to be careful in the cases where too many objects would be created, like when iterating docs/values, etc. That specific case you link to would be a good candidate in my mind. On Wed, Apr 10, 2019 at 10:20 AM Diego Ceccarelli (BLOOMBERG/ LONDON) < dceccarel..

Using util.Optional instead of a raw null?

2019-04-10 Thread Diego Ceccarelli (BLOOMBERG/ LONDON)
Hi *, I have a general question about using Optional instead of a raw null: I have noticed that some functions in Solr are dealing with input parameters that might be null, these parameters might be wrapped into Optional - to avoid forgetting that they might be nulls and also to make clear that