Re: asciidoctor in gradle build

2019-11-13 Thread Erick Erickson
NP, I’m just grateful it’s more than just me working on it ;) > On Nov 13, 2019, at 8:50 AM, Cassandra Targett wrote: > > The license .sha file was already updated, the right version just wasn’t in > that build.gradle. Sorry again for the added noise, merging is messy ;-). > > Cassandra > On

Re: asciidoctor in gradle build

2019-11-13 Thread Cassandra Targett
The license .sha file was already updated, the right version just wasn’t in that build.gradle. Sorry again for the added noise, merging is messy ;-). Cassandra On Nov 13, 2019, 7:47 AM -0600, Cassandra Targett , wrote: > Yes, Erick, that was the cause of the problem Dawid noticed - I just

Re: asciidoctor in gradle build

2019-11-13 Thread Cassandra Targett
Yes, Erick, that was the cause of the problem Dawid noticed - I just pushed a change to fix it before I saw your mail. I might need to fix the licenses on that branch, but I’ll check that now too. I’ll confess I don’t think I re-ran the bareBonesHtmlValidation task after I’d made other changes

Re: asciidoctor in gradle build

2019-11-13 Thread Erick Erickson
Dawid and Cassandra: In the gradle_8 checkout the versions.props file has: org.asciidoctor:asciidoctorj=1.6.0-alpha.5 which makes me nervous, so I changed to org.asciidoctor:asciidoctorj=1.6.2 in my local checkout. This may be the root of my issues for all I know. Cassandra: this may be

Re: asciidoctor in gradle build

2019-11-13 Thread Cassandra Targett
I’ll look into it now. Cassandra On Nov 12, 2019, 4:09 PM -0600, Dawid Weiss , wrote: > Hi Cassandra, > > I fixed relative links issue (on jira/SOLR-13452_gradle_8) but there's > still something odd with asciidoctor -- while the html site generation > is fine now the validation isn't: > >

asciidoctor in gradle build

2019-11-12 Thread Dawid Weiss
Hi Cassandra, I fixed relative links issue (on jira/SOLR-13452_gradle_8) but there's still something odd with asciidoctor -- while the html site generation is fine now the validation isn't: .\gradlew -p solr\solr-ref-guide bareBonesHtmlValidation it's the same problem as before -- fails on two