That explains a lot. Thanks Mike!
On 13 Mar 2015 00:46, Michael McCandless luc...@mikemccandless.com
wrote:
On Thu, Mar 12, 2015 at 5:38 PM, Yonik Seeley ysee...@gmail.com wrote:
On Thu, Mar 12, 2015 at 8:04 PM, Ramkumar R. Aiyengar
andyetitmo...@gmail.com wrote:
This actually brings me to
Hey Yonik,
I think you've inadvertently added a couple of deprecated methods back in here?
Modified:
lucene/dev/branches/branch_5x/solr/core/src/java/org/apache/solr/parser/CharStream.java
URL:
Looks like the original removal of these deprecated methods happened
in SOLR-6976, but probably should not have given that this is a
generated file?
-Yonik
On Thu, Mar 12, 2015 at 11:19 AM, Yonik Seeley ysee...@gmail.com wrote:
On Thu, Mar 12, 2015 at 11:08 AM, Alan Woodward a...@flax.co.uk
On Thu, Mar 12, 2015 at 11:08 AM, Alan Woodward a...@flax.co.uk wrote:
Hey Yonik,
I think you've inadvertently added a couple of deprecated methods back in
here?
Hmmm, but CharStream.java is generated by JavaCC...
When I got a compile error in FastCharStream.java, I simply copied the
lucene
Ah, OK. Sorry for the noise!
On 12 Mar 2015, at 15:19, Yonik Seeley wrote:
On Thu, Mar 12, 2015 at 11:08 AM, Alan Woodward a...@flax.co.uk wrote:
Hey Yonik,
I think you've inadvertently added a couple of deprecated methods back in
here?
Hmmm, but CharStream.java is generated by
This actually brings me to a question I have had for a while. Why do we
check in auto generated code? Shouldn't the build system run javacc as a
prereq to compiling instead?
On 12 Mar 2015 18:08, Alan Woodward a...@flax.co.uk wrote:
Ah, OK. Sorry for the noise!
On 12 Mar 2015, at 15:19, Yonik
On Thu, Mar 12, 2015 at 8:04 PM, Ramkumar R. Aiyengar
andyetitmo...@gmail.com wrote:
This actually brings me to a question I have had for a while. Why do we
check in auto generated code? Shouldn't the build system run javacc as a
prereq to compiling instead?
Historically, the compilation
On Thu, Mar 12, 2015 at 5:38 PM, Yonik Seeley ysee...@gmail.com wrote:
On Thu, Mar 12, 2015 at 8:04 PM, Ramkumar R. Aiyengar
andyetitmo...@gmail.com wrote:
This actually brings me to a question I have had for a while. Why do we
check in auto generated code? Shouldn't the build system run