Re: [VOTE] Release Lucene/Solr 8.8.0 RC2

2021-01-25 Thread Timothy Potter
Thanks Noble! +1 SUCCESS! [1:24:28.212370] (my internet is super slow today) Re-ran all the Solr operator tests and verified the Cloud graph UI renders correctly now. On Mon, Jan 25, 2021 at 3:22 AM Noble Paul wrote: > Please vote for release candidate 2 for Lucene/Solr 8.8.0 > > The

Re: Merging segment parts concurrently (SegmentMerger)

2021-01-25 Thread David Smiley
I suppose we should add a CallerRunsMergeScheduler (a new superclass of SerialMergeScheduler)? Or make this aspect of SMS configurable. We might use a semaphore to control how many callers can merge at once (1 == SMS of today, larger for expanded). It might be debatable if it is then "serial"

Re: Merging segment parts concurrently (SegmentMerger)

2021-01-25 Thread Michael Sokolov
At least in theory, since the segmentWriteState is shared among these phases, there could be dependencies, but it seems as if it ought to be limited to making sure that the FieldInfos are written last? This is pure speculation, I haven't dug deeply in the code. However, it would be necessary to

Re: Consider Removing the `@` Special Character from RegExp

2021-01-25 Thread Marcus Eagan
That's right. It's optional. I think we should remove it unless we have a good reason to keep it. I just think that it's maddening and unnecessary. Perhaps, I am the only one? On Fri, Jan 22, 2021 at 7:54 AM Gus Heck wrote: > I think it's already an optional feature; if you construct the regexp

Re: Merging segment parts concurrently (SegmentMerger)

2021-01-25 Thread Dawid Weiss
Thanks for early feedback. I freely admit I never had to touch codecs so I'm not sure what ordering dependencies need to be respected. But it's certainly something I'd like to look into since that "last" segment merge can now take ~10 minutes on mostly idle CPU (64 cores, remember...) and I/O.

Re: [VOTE] Release Lucene/Solr 8.8.0 RC2

2021-01-25 Thread Tomás Fernández Löbbe
Thanks Noble! And thanks for fixing that concurrency issue, I'd hit it but didn't have time to investigate it. +1 SUCCESS! [0:58:32.036482] On Mon, Jan 25, 2021 at 10:19 AM Timothy Potter wrote: > Thanks Noble! > > +1 SUCCESS! [1:24:28.212370] (my internet is super slow today) > > Re-ran all

Re: [DISCUSS] ConfigSet ZK to file system fallback

2021-01-25 Thread David Smiley
I'm not entirely sure how to react to the feedback. Maybe in listing multiple benefits and a follow-on proposal, I inadvertently opened doors to distracting points. I know I can be guilty of scope creep. My proposal has no impact on where JARs go, and so let's not discuss lib directories, the

Re: Merging segment parts concurrently (SegmentMerger)

2021-01-25 Thread Michael Sokolov
It makes sense to me. I don't have the full picture, but I did just implement merging for vector format, and that at least, could be done fully concurrent with other formats. I expect the same is true of DocValues, Terms, etc. I'm not sure about the different kinds of DocValues - they might want

Merging segment parts concurrently (SegmentMerger)

2021-01-25 Thread Dawid Weiss
Hey everyone, I'm trying to cut the total wall-time of indexing for some fairly large document collections on machines with a high CPU count (> 32 indexing threads). So far my observations are: 1) I resigned from using the concurrent merge scheduler in favor of "same thread" merging. This means

Re: Separate git repo(s) for Solr modules

2021-01-25 Thread Ishan Chattopadhyaya
I haven't been able to follow up on creation of the extras repo, but more importantly I wanted to respond to Hoss. I'm out on an emergency for a week or so, shall resume then. If there's a decision on this until then, I shall accept it. On Mon, 25 Jan, 2021, 9:04 am Jason Gerlowski, wrote: >

[VOTE] Release Lucene/Solr 8.8.0 RC2

2021-01-25 Thread Noble Paul
Please vote for release candidate 2 for Lucene/Solr 8.8.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.8.0-RC2-revb10659f0fc18b58b90929cfdadde94544d202c4a/ python3 -u dev-tools/scripts/smokeTestRelease.py \