Re: New branch and feature freeze for Lucene 9.6.0

2023-05-02 Thread Ishan Chattopadhyaya
Don't remember the specifics, but I ran into GPG issues during Solr 9.1.0 release. The fix for me was https://github.com/apache/solr/pull/1125, but I don't know if this is the same problem or if it is applicable in Lucene's case. On Tue, 2 May 2023 at 18:27, Alan Woodward wrote: > I am fighting

Re: New branch and feature freeze for Lucene 9.6.0

2023-05-02 Thread Alan Woodward
I am fighting with gradle and GPG yet again… Gradle fails when trying to sign artefacts with the message "Cannot perform signing task ':lucene:distribution:signReleaseArchives' because it has no configured signatory”. I have GPG configured in ~/.gradle/gradle.properties as follows:

Unnecessary float[256] allocation on every (non-scoring) BM25Scorer

2023-05-02 Thread Michael Froh
Hi all, I was looking into a customer issue where they noticed some increased GC time after upgrading from Lucene 7.x to 9.x. After taking some heap dumps from both systems, the big difference was tracked down to the float[256] allocated (as a norms cache) when creating a BM25Scorer (in

[VOTE] Release Lucene 9.6.0 RC1

2023-05-02 Thread Alan Woodward
Please vote for release candidate 1 for Lucene 9.6.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-9.6.0-RC1-rev-246ac4bcbe6c0ea7bebcc4f90b2be0536f00d842 You can run the smoke tester directly with this command: python3 -u

Re: Unnecessary float[256] allocation on every (non-scoring) BM25Scorer

2023-05-02 Thread Robert Muir
On Tue, May 2, 2023 at 12:49 PM Michael Froh wrote: > > Hi all, > > I was looking into a customer issue where they noticed some increased GC time > after upgrading from Lucene 7.x to 9.x. After taking some heap dumps from > both systems, the big difference was tracked down to the float[256]

Why two TermAndBoost classes

2023-05-02 Thread Gus Heck
Was fishing around in parsers in solr and discovered that we have two different term and boost classes in Lucene. Is this really desirable? They are quite similar except one implements a notion of equality, and doesn't copy the BytesRef when created whereas the other relies on object equality and

Re: Unnecessary float[256] allocation on every (non-scoring) BM25Scorer

2023-05-02 Thread Robert Muir
On Tue, May 2, 2023 at 3:24 PM Michael Froh wrote: > > > This seems ok if it isn't invasive. I still feel like something is > > "off" if you are seeing GC time from 1KB-per-segment allocation. Do > > you have way too many segments? > > From what I saw, it's 1KB per "leaf query" to create the

Re: Unnecessary float[256] allocation on every (non-scoring) BM25Scorer

2023-05-02 Thread Michael Froh
> So I'm actually still confused why this float[256] stands out in your > measurejments vs two long[128]'s. Maybe its a profiler ghost? Huh... that's a really good point. I'm going to spend a bit more time digging and see if I can reliably reproduce it on my own machine. I've just been comparing

Re: Unnecessary float[256] allocation on every (non-scoring) BM25Scorer

2023-05-02 Thread Robert Muir
On Tue, May 2, 2023 at 2:34 PM Robert Muir wrote: > > On Tue, May 2, 2023 at 12:49 PM Michael Froh wrote: > > > > Hi all, > > > > I was looking into a customer issue where they noticed some increased GC > > time after upgrading from Lucene 7.x to 9.x. After taking some heap dumps > > from both

Re: Unnecessary float[256] allocation on every (non-scoring) BM25Scorer

2023-05-02 Thread Michael Froh
> This seems ok if it isn't invasive. I still feel like something is > "off" if you are seeing GC time from 1KB-per-segment allocation. Do > you have way too many segments? >From what I saw, it's 1KB per "leaf query" to create the BM25Scorer instance (at the Weight level), but then that

Re: Why two TermAndBoost classes

2023-05-02 Thread Alessandro Benedetti
Adding to cc Daniele who worked on this quite recently! Cheers On Tue, 2 May 2023, 21:12 Gus Heck, wrote: > Was fishing around in parsers in solr and discovered that we have two > different term and boost classes in Lucene. Is this really desirable? They > are quite similar except one

Re: [VOTE] Release Lucene 9.6.0 RC1

2023-05-02 Thread Nhat Nguyen
+1. Thanks Alan! SUCCESS! [0:48:46.465752] On Tue, May 2, 2023 at 11:33 AM Alan Woodward wrote: > Please vote for release candidate 1 for Lucene 9.6.0 > > The artifacts can be downloaded from: > >