Can we move discussion about the implementation to the JIRA issue or the PR?
I'm not a lawyer, so not playing with the GPL fire is the easiest way for
me to avoid getting burned. The regex I have is pretty straightforward, I
do not feel like it is a great cause for alarm.
On Fri, Sep 17, 2021 at
Given that we don't ship the code or binaries that involve that python
library, do we need to care about the license? I'm skeptical of hand rolled
regex and would rather favour either of the libraries Jan mentioned. Just
my two cents.
On Sat, 18 Sep, 2021, 12:02 am Mike Drob, wrote:
> The
The second library you linked, Jan, is AGPL. Thank you for continuing to
look for alternatives.
I have some regular expressions cooked up locally that I think will let us
read the split lines going forward, and will put up the patch shortly.
On Fri, Sep 17, 2021 at 7:45 AM Yuval Paz
wrote:
>
Not sure if this is something can be changed easily, but if the problem is
caused by some parsers don't know how to parse line wrapping in the middle
of the Hash why not moving the hash completely to the new line (the
specification allow new line at any point in the value)?
The commit hash + date
Hi Vigya, I agree, we should describe the github PR workflow. However
patches are still in use, too, so we should have instructions that are
agnostic as to the method, I think. We want to be open to
contributions in any form, as long as we can grok it.
As for the documentation format, I'm not
That was not my point, there are several choices - this from 2020 which also
work ootb: https://pypi.org/project/java-manifest/
It has TWO stars :), conforms to the specs and solves our needs in pure
python... If other tools cannot follow a spec then IMO that's their problem,
not ours.
Jan
>
Sure, but that package is archived/read-only, GPLv3. with 3 watchers and 1 star.
On Fri, Sep 17, 2021 at 4:27 AM Jan Høydahl wrote:
>
> Let's just follow the spec and move on.
>
> Just tested this python package, which has no problem parsing the problematic
> manifest
Let's just follow the spec and move on.
Just tested this python package, which has no problem parsing the problematic
manifest https://pypi.org/project/jarmanifest/
>>> manifest.getAttributes("/tmp/lucene-manifest.mf")
[{'implementationversion': '9.0.0-SNAPSHOT
We could do a few things to keep everyone happy -
1) keep abbreviated hash in the Implementat-Version and use a separate
manifest entry to store a full hash.
2) use a longer version for git show (abbrev=num) so that the chance of
collisions in the future is minimized. It's still not a full hash
10 matches
Mail list logo
