[jira] [Resolved] (SOLR-13739) Managed resource observers have to be added only once

2019-09-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13739. - Fix Version/s: 8.3 Assignee: David Smiley Resolution: Fixed Thanks for

[jira] [Commented] (LUCENE-8921) IndexSearcher.termStatistics should not require TermStates but docFreq and totalTermFreq

2019-09-13 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929311#comment-16929311 ] David Smiley commented on LUCENE-8921: -- Barring further feedback, I'll commit what Bruno has

[jira] [Updated] (SOLR-1954) Highlighter component should expose snippet character offsets and the score.

2019-09-10 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-1954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-1954: --- Attachment: SOLR-1954.patch Assignee: David Smiley Status: Open (was: Open) At the

[jira] [Commented] (SOLR-13745) Test should close resources: AtomicUpdateProcessorFactoryTest

2019-09-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926002#comment-16926002 ] David Smiley commented on SOLR-13745: - Aha; this ObjectReleaseTracker looks super easy to use.  

[jira] [Commented] (LUCENE-8638) Remove deprecated code in master

2019-09-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925655#comment-16925655 ] David Smiley commented on LUCENE-8638: -- The branch doesn't pass precommit now because javadocs in

[jira] [Commented] (SOLR-13138) Remove deprecated code in master

2019-09-09 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925654#comment-16925654 ] David Smiley commented on SOLR-13138: - Two Jira issues but one branch, and thus presumably one commit

[jira] [Commented] (SOLR-13745) Test should close resources: AtomicUpdateProcessorFactoryTest

2019-09-07 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924960#comment-16924960 ] David Smiley commented on SOLR-13745: - Aha; very interesting. Yeah I agree on your assessment. It'd

[jira] [Commented] (SOLR-13677) All Metrics Gauges should be unregistered by the objects that registered them

2019-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924616#comment-16924616 ] David Smiley commented on SOLR-13677: - +Yes, lets revert this now then+. I appreciate that [~ab] is

[jira] [Resolved] (SOLR-13745) Test should close resources: AtomicUpdateProcessorFactoryTest

2019-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13745. - Fix Version/s: 8.3 Resolution: Fixed > Test should close resources:

[jira] [Resolved] (LUCENE-8753) New PostingFormat - UniformSplit

2019-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8753. -- Fix Version/s: 8.3 Resolution: Fixed Thanks [~bruno.roustant] and [~juan.duran]! BTW

[jira] [Commented] (SOLR-13728) Fail partial updates if it would inadvertently remove nested docs

2019-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924482#comment-16924482 ] David Smiley commented on SOLR-13728: - I'm puzzled but lets discuss further in SOLR-13745 -- an issue

[jira] [Created] (SOLR-13745) Test should close resources: AtomicUpdateProcessorFactoryTest

2019-09-06 Thread David Smiley (Jira)
David Smiley created SOLR-13745: --- Summary: Test should close resources: AtomicUpdateProcessorFactoryTest Key: SOLR-13745 URL: https://issues.apache.org/jira/browse/SOLR-13745 Project: Solr

[jira] [Resolved] (SOLR-13728) Fail partial updates if it would inadvertently remove nested docs

2019-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13728. - Resolution: Fixed [~hossman] I'm confident you mean to comment on SOLR-13523 (June 20th), not

[jira] [Commented] (SOLR-13728) Fail partial updates if it would inadvertently remove nested docs

2019-09-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924433#comment-16924433 ] David Smiley commented on SOLR-13728: - I'll investigate [~hossman]. I had run the tests right before

[jira] [Updated] (SOLR-13738) UnifiedHighlighter can't highlight GraphQuery

2019-09-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13738: Component/s: highlighter > UnifiedHighlighter can't highlight GraphQuery >

[jira] [Commented] (SOLR-13738) UnifiedHighlighter can't highlight GraphQuery

2019-09-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923921#comment-16923921 ] David Smiley commented on SOLR-13738: - Likely caused by LUCENE-8848. Ironically the goal of that one

[jira] [Updated] (SOLR-13728) Fail partial updates if it would inadvertently remove nested docs

2019-09-05 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13728: Fix Version/s: 8.3 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Created] (LUCENE-8965) ConcurrentMergeScheduler should maybe sometimes do synchronously

2019-09-04 Thread David Smiley (Jira)
David Smiley created LUCENE-8965: Summary: ConcurrentMergeScheduler should maybe sometimes do synchronously Key: LUCENE-8965 URL: https://issues.apache.org/jira/browse/LUCENE-8965 Project: Lucene -

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2019-09-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922749#comment-16922749 ] David Smiley commented on LUCENE-8962: -- The existing MergeTrigger mechanism is a way to

[jira] [Commented] (SOLR-9658) Caches should have an optional way to clean if idle for 'x' mins

2019-09-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922432#comment-16922432 ] David Smiley commented on SOLR-9658: Sure; I don't mean to stand in your way. > Caches should have an

[jira] [Assigned] (SOLR-13705) Double-checked Locking Should Not be Used

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned SOLR-13705: --- Assignee: David Smiley > Double-checked Locking Should Not be Used >

[jira] [Commented] (LUCENE-8962) Can we merge small segments during refresh, for faster searching?

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921796#comment-16921796 ] David Smiley commented on LUCENE-8962: -- At Salesforce I worked on a custom merge policy to better

[jira] [Commented] (SOLR-13655) Cut Over Collections.unmodifiableSet usages to Set.*

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921733#comment-16921733 ] David Smiley commented on SOLR-13655: - This is a trivial master-only change since it requires Java

[jira] [Commented] (SOLR-9658) Caches should have an optional way to clean if idle for 'x' mins

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921723#comment-16921723 ] David Smiley commented on SOLR-9658: Do we as a project really want to implement our own caches or is

[jira] [Closed] (SOLR-3486) The memory size of Solr caches should be configurable

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-3486. -- > The memory size of Solr caches should be configurable >

[jira] [Resolved] (SOLR-3486) The memory size of Solr caches should be configurable

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-3486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-3486. Resolution: Duplicate > The memory size of Solr caches should be configurable >

[jira] [Resolved] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8403. -- Resolution: Won't Fix > Support 'filtered' term vectors - don't require all terms to be

[jira] [Closed] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-09-03 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed LUCENE-8403. > Support 'filtered' term vectors - don't require all terms to be present >

[jira] [Commented] (SOLR-13709) Race condition on core reload while core is still loading?

2019-09-02 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921141#comment-16921141 ] David Smiley commented on SOLR-13709: - bq. have the reload operation wait until core loading was

[jira] [Commented] (SOLR-13690) Migrate field type configurations in default/example schema files to look up factories by "name"

2019-09-01 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920433#comment-16920433 ] David Smiley commented on SOLR-13690: - [~tomoko] it's very likely that in this issue or similar

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

2019-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920296#comment-16920296 ] David Smiley commented on LUCENE-8753: -- Oh; I was just looking at PR #828, by the way. As I write

[jira] [Commented] (LUCENE-8753) New PostingFormat - UniformSplit

2019-08-31 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920294#comment-16920294 ] David Smiley commented on LUCENE-8753: -- Bruno: Why a new PR? Please don't do that next time

[jira] [Updated] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree

2019-08-30 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8758: - Fix Version/s: (was: 8.x) 8.3 Resolution: Fixed Status:

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919200#comment-16919200 ] David Smiley commented on SOLR-12638: - Thanks Moshe; you are right. Still, I think there is probably

[jira] [Updated] (SOLR-13728) Fail partial updates if it would inadvertently remove nested docs

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13728: Attachment: SOLR-13728.patch Status: Patch Available (was: Patch Available) > Fail

[jira] [Updated] (SOLR-13728) Fail partial updates if it would inadvertently remove nested docs

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13728: Status: Patch Available (was: Open) > Fail partial updates if it would inadvertently remove

[jira] [Created] (SOLR-13728) Fail partial updates if it would inadvertently remove nested docs

2019-08-29 Thread David Smiley (Jira)
David Smiley created SOLR-13728: --- Summary: Fail partial updates if it would inadvertently remove nested docs Key: SOLR-13728 URL: https://issues.apache.org/jira/browse/SOLR-13728 Project: Solr

[jira] [Updated] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8758: - Status: Patch Available (was: Open) > Class Field levelN is not populated correctly in

[jira] [Assigned] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reassigned LUCENE-8758: Assignee: David Smiley > Class Field levelN is not populated correctly in QuadPrefixTree

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918913#comment-16918913 ] David Smiley commented on LUCENE-8403: -- RE a separate field:  That's a valid approach, yes.  

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-08-29 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918711#comment-16918711 ] David Smiley commented on LUCENE-8403: -- {quote}I understand the approaches – your approach seems to

[jira] [Commented] (LUCENE-8951) Create issues@ and builds@ lists and update notifications

2019-08-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917738#comment-16917738 ] David Smiley commented on LUCENE-8951: -- Ugh; why do mailing lists have to be such a usability

[jira] [Commented] (SOLR-9418) Statistical Phrase Identifier

2019-08-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-9418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916697#comment-16916697 ] David Smiley commented on SOLR-9418: I just want to point out that there's no trace of this in the

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-08-27 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916687#comment-16916687 ] David Smiley commented on LUCENE-8403: -- bq. Does it make sense for me to adapt the patch to support

[jira] [Commented] (LUCENE-8403) Support 'filtered' term vectors - don't require all terms to be present

2019-08-26 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916316#comment-16916316 ] David Smiley commented on LUCENE-8403: -- Atri, I appreciate you put some effort into this but your

[jira] [Commented] (LUCENE-8758) Class Field levelN is not populated correctly in QuadPrefixTree

2019-08-25 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915422#comment-16915422 ] David Smiley commented on LUCENE-8758: -- Go for it! > Class Field levelN is not populated correctly

[jira] [Updated] (SOLR-11601) geodist fails for some fields when field is in parenthesis instead of sfield param

2019-08-23 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-11601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-11601: Fix Version/s: 8.3 Resolution: Fixed Status: Resolved (was: Patch Available)

[jira] [Commented] (SOLR-12393) ExpandComponent only calculates the score of expanded docs when sorted by score

2019-08-22 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16913780#comment-16913780 ] David Smiley commented on SOLR-12393: - I reviewed the code but admittedly not the test. I don't

[jira] [Commented] (SOLR-12393) ExpandComponent only calculates the score of expanded docs when sorted by score

2019-08-21 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912815#comment-16912815 ] David Smiley commented on SOLR-12393: - I'll review this Munendra; thanks for looking. What'd

[jira] [Resolved] (LUCENE-8755) QuadPrefixTree robustness: can throw exception while indexing a point at high precision

2019-08-20 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8755. -- Fix Version/s: 8.3 Assignee: David Smiley Resolution: Fixed _Thanks Chongchen

[jira] [Issue Comment Deleted] (LUCENE-8755) QuadPrefixTree robustness: can throw exception while indexing a point at high precision

2019-08-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8755: - Comment: was deleted (was: As I write this, there is strangely no automated linking here to the

[jira] [Commented] (LUCENE-8755) QuadPrefixTree robustness: can throw exception while indexing a point at high precision

2019-08-07 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902540#comment-16902540 ] David Smiley commented on LUCENE-8755: -- As I write this, there is strangely no automated linking

[jira] [Resolved] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-08-06 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8883. -- Resolution: Fixed Fix Version/s: 8.3 > CHANGES.txt: Auto add issue categories on new

[jira] [Commented] (SOLR-11866) Support efficient subset matching in query elevation rules

2019-08-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899974#comment-16899974 ] David Smiley commented on SOLR-11866: - Thanks Munendra... I pushed the commit just now; I had

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

2019-08-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899969#comment-16899969 ] David Smiley commented on SOLR-13593: - Both name & class seems error prone; can't we simply disallow

[jira] [Updated] (SOLR-11866) Support efficient subset matching in query elevation rules

2019-08-05 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-11866: Resolution: Fixed Fix Version/s: 8.3 Status: Resolved (was: Patch Available)

[jira] [Commented] (SOLR-5381) Split Clusterstate and scale

2019-08-02 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-5381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899026#comment-16899026 ] David Smiley commented on SOLR-5381: Shall we mark this closed now? I see this as done, save for one

[jira] [Resolved] (LUCENE-8906) Lucene50PostingsReader.postings() casts BlockTermState param to private IntBlockTermState

2019-08-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved LUCENE-8906. -- Resolution: Fixed Assignee: David Smiley Fix Version/s: 8.3 Merged PR.

[jira] [Commented] (LUCENE-8941) Build wildcard matches more lazily

2019-08-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898394#comment-16898394 ] David Smiley commented on LUCENE-8941: -- It'd be clearer if TermsEnumDisjunctionMatchesIterator had

[jira] [Commented] (SOLR-13523) Atomic Update results in NullPointerException

2019-07-31 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897607#comment-16897607 ] David Smiley commented on SOLR-13523: - I think that warrants it's own discussion on

[jira] [Updated] (SOLR-13669) [CVE-2019-0193] Remote Code Execution via DataImportHandler

2019-07-31 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13669: Description: The DataImportHandler, an optional but popular module to pull in data from databases

[jira] [Updated] (SOLR-13669) [CVE-2019-0193] Remote Code Execution via DataImportHandler

2019-07-31 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-13669: Security: Public (was: Private (Security Issue)) > [CVE-2019-0193] Remote Code Execution via

[jira] [Commented] (SOLR-13658) Discuss adding the new "var" construct to the forbidden API list.

2019-07-30 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896578#comment-16896578 ] David Smiley commented on SOLR-13658: - +1 to prevent use of "var" until Solr 8 is finished. The

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2019-07-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895597#comment-16895597 ] David Smiley commented on LUCENE-8776: -- I think your response/question is about tokenstream

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-28 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16894821#comment-16894821 ] David Smiley commented on SOLR-12638: - RE schema: Yes that's right Adi. No special additional

[jira] [Commented] (LUCENE-8776) Start offset going backwards has a legitimate purpose

2019-07-26 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893852#comment-16893852 ] David Smiley commented on LUCENE-8776: -- [~venkat11] I am curious if you've tried the latest version

[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete

2019-07-26 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16893833#comment-16893833 ] David Smiley commented on LUCENE-8369: -- IMO to most users anything beyond points, rectangles, and

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892757#comment-16892757 ] David Smiley commented on SOLR-12638: - CC [~moshebla] I found the cause of this bug or maybe non-bug

[jira] [Commented] (LUCENE-8369) Remove the spatial module as it is obsolete

2019-07-25 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892745#comment-16892745 ] David Smiley commented on LUCENE-8369: -- Lots of awesome functionality _commonly_ needed in search

[jira] [Updated] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8883: - Attachment: LUCENE-8883.patch Status: Open (was: Open) In the latest patch I added an

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16892157#comment-16892157 ] David Smiley commented on SOLR-12638: - Partial updates of any part of a nested doc (i.e. even to a

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-23 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16891514#comment-16891514 ] David Smiley commented on SOLR-12638: - Ronen, your explanation wasn't clear to me since using

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-16 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16886112#comment-16886112 ] David Smiley commented on LUCENE-8883: -- Thanks for the review Christine; I'll rename that variable.

[jira] [Closed] (SOLR-13631) Java 11 date parsing causing NPEs

2019-07-14 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley closed SOLR-13631. --- > Java 11 date parsing causing NPEs > - > > Key:

[jira] [Resolved] (SOLR-13631) Java 11 date parsing causing NPEs

2019-07-14 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-13631. - Resolution: Duplicate I dug into this; see my first comment on : SOLR-13606 > Java 11 date

[jira] [Commented] (SOLR-12638) Support atomic updates of nested/child documents for nested-enabled schema

2019-07-11 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16883498#comment-16883498 ] David Smiley commented on SOLR-12638: - Yes all documents (parent/child) can be atomically updated. >

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882617#comment-16882617 ] David Smiley commented on LUCENE-8883: -- Optimization really does seam useful & meaningful, and I

[jira] [Updated] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8883: - Attachment: LUCENE-8883.patch Status: Open (was: Open) Nice unix piping :) In this

[jira] [Commented] (SOLR-10377) Improve readability of the explain output for JSON format

2019-07-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882580#comment-16882580 ] David Smiley commented on SOLR-10377: - I really don't think everyone would like structured=true by

[jira] [Commented] (SOLR-10377) Improve readability of the explain output for JSON format

2019-07-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882004#comment-16882004 ] David Smiley commented on SOLR-10377: - Thanks for the reminder of that obscure parameter. I think

[jira] [Commented] (SOLR-13578) Implement a generic Resource Manager for monitoring and controlling limited resources

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881574#comment-16881574 ] David Smiley commented on SOLR-13578: - This looks useful. For example I believe [~mkhludnev] was

[jira] [Commented] (SOLR-13579) Create resource management API

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881572#comment-16881572 ] David Smiley commented on SOLR-13579: - Oh I see this is a sub-task, and the parent task has a fine

[jira] [Commented] (SOLR-13579) Create resource management API

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881571#comment-16881571 ] David Smiley commented on SOLR-13579: - Could you please add an issue description? The title is not

[jira] [Commented] (SOLR-13606) DateTimeFormatter Exception on Create Core

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881518#comment-16881518 ] David Smiley commented on SOLR-13606: - Nonetheless it's bad that the JDK throws an NPE, although not

[jira] [Reopened] (SOLR-10377) Improve readability of the explain output for JSON format

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reopened SOLR-10377: - > Improve readability of the explain output for JSON format >

[jira] [Commented] (SOLR-10377) Improve readability of the explain output for JSON format

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-10377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881507#comment-16881507 ] David Smiley commented on SOLR-10377: - The indentation problem has been a long-standing problem no

[jira] [Commented] (SOLR-13593) Allow to specify analyzer components by their SPI names in schema definition

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881500#comment-16881500 ] David Smiley commented on SOLR-13593: - I really like this change! Love "name". I think you can make

[jira] [Commented] (SOLR-13257) Enable replica routing affinity for better cache usage

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881478#comment-16881478 ] David Smiley commented on SOLR-13257: - Cool! > Enable replica routing affinity for better cache

[jira] [Commented] (LUCENE-8069) Allow index sorting by field length

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881476#comment-16881476 ] David Smiley commented on LUCENE-8069: -- Also; is luceneutil assuming the search query doesn't want

[jira] [Commented] (LUCENE-8069) Allow index sorting by field length

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881474#comment-16881474 ] David Smiley commented on LUCENE-8069: -- Index sorting means slower indexing (naturally). How much

[jira] [Commented] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-09 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881452#comment-16881452 ] David Smiley commented on LUCENE-8883: -- Thanks Adrien for determining this list of actual usages!

[jira] [Commented] (SOLR-13375) Dimensional Routed Aliases

2019-07-08 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880918#comment-16880918 ] David Smiley commented on SOLR-13375: - Fascinating bug to track down; congrats on that!  I hope it

[jira] [Updated] (LUCENE-8883) CHANGES.txt: Auto add issue categories on new releases

2019-07-08 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated LUCENE-8883: - Attachment: LUCENE-8883.patch Status: Open (was: Open) Here's the patch.  Note I have

[jira] [Commented] (SOLR-13605) HttpSolrClient.Builder.withHttpClient() is useless for the purpose of setting client scoped so/connect timeouts

2019-07-03 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-13605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16878271#comment-16878271 ] David Smiley commented on SOLR-13605: - Thorough analysis Hoss; well researched! >

[jira] [Created] (SOLR-13604) if updateLog isn't in config, complain loudly if it's needed for SolrCloud

2019-07-03 Thread David Smiley (JIRA)
David Smiley created SOLR-13604: --- Summary: if updateLog isn't in config, complain loudly if it's needed for SolrCloud Key: SOLR-13604 URL: https://issues.apache.org/jira/browse/SOLR-13604 Project: Solr

[jira] [Commented] (LUCENE-8895) Switch all FSTs to use direct addressing optimization

2019-07-03 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16877843#comment-16877843 ] David Smiley commented on LUCENE-8895: -- Dare I ask:  Did you intend to only Deprecate the first

[jira] [Reopened] (LUCENE-8781) Explore FST direct array arc encoding

2019-07-02 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley reopened LUCENE-8781: -- Assignee: Mike Sokolov (was: Dawid Weiss) Just checking: you will continue to leave

[jira] [Commented] (LUCENE-8781) Explore FST direct array arc encoding

2019-06-29 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875599#comment-16875599 ] David Smiley commented on LUCENE-8781: -- [~dweiss] or [~jpountz] do you have any opinion on wether

[jira] [Commented] (LUCENE-8855) Add Accountable to some Query implementations

2019-06-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874402#comment-16874402 ] David Smiley commented on LUCENE-8855: -- Yeah I agree!  The bug distinction on SOLR-13003 is

[jira] [Resolved] (SOLR-4197) EDismax allows end users to use local params in q= to override global params

2019-06-26 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-4197. Resolution: Fixed Fix Version/s: 7.2 > EDismax allows end users to use local params in q= to

  1   2   3   4   5   6   7   8   9   10   >