[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

2018-05-11 Thread ilaygit
Github user ilaygit commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/162#discussion_r187527922 --- Diff: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java --- @@ -1270,7 +1270,7 @@ private void

[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

2018-05-02 Thread diegoceccarelli
Github user diegoceccarelli commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/162#discussion_r185490261 --- Diff: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java --- @@ -1414,10 +1267,17 @@ private void

[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

2018-05-02 Thread ilaygit
Github user ilaygit commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/162#discussion_r185438730 --- Diff: solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java --- @@ -1414,10 +1267,17 @@ private void

[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

2017-05-22 Thread romseygeek
Github user romseygeek commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/162#discussion_r117773779 --- Diff: lucene/grouping/src/java/org/apache/lucene/search/grouping/TopGroupsCollector.java --- @@ -39,6 +39,14 @@ private final Sort

[GitHub] lucene-solr pull request #162: SOLR-8776: Support RankQuery in grouping

2017-02-28 Thread diegoceccarelli
GitHub user diegoceccarelli opened a pull request: https://github.com/apache/lucene-solr/pull/162 SOLR-8776: Support RankQuery in grouping Update SOLR-8776 to current master - Reranking and grouping work together in non-distributed setting when grouping is done by field