[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876188#comment-15876188
]
Michael McCandless commented on LUCENE-7465:
That test failure was actually a real bug in
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876185#comment-15876185
]
ASF subversion and git services commented on LUCENE-7465:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876181#comment-15876181
]
ASF subversion and git services commented on LUCENE-7465:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875772#comment-15875772
]
Michael McCandless commented on LUCENE-7465:
Thanks [~steve_rowe]; I'll have a look.
> Add a
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875092#comment-15875092
]
Steve Rowe commented on LUCENE-7465:
Another reproducing TestRandomChains master seed, from
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867599#comment-15867599
]
Michael McCandless commented on LUCENE-7465:
OK I pushed a fix... sneaky wrong random
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867598#comment-15867598
]
ASF subversion and git services commented on LUCENE-7465:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867597#comment-15867597
]
ASF subversion and git services commented on LUCENE-7465:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866854#comment-15866854
]
Michael McCandless commented on LUCENE-7465:
Thanks [~steve_rowe], I'll dig.
> Add a
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866514#comment-15866514
]
Steve Rowe commented on LUCENE-7465:
My Jenkins found a reproducing seed on master for a
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864235#comment-15864235
]
ASF subversion and git services commented on LUCENE-7465:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864078#comment-15864078
]
ASF subversion and git services commented on LUCENE-7465:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842872#comment-15842872
]
David Smiley commented on LUCENE-7465:
--
bq. (Adrien) I like the separate factory idea better, it
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842694#comment-15842694
]
Dawid Weiss commented on LUCENE-7465:
-
bq. I think this is interesting, but let's explore it on a
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842611#comment-15842611
]
Michael McCandless commented on LUCENE-7465:
Whoa, this issue almost dropped past the event
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547870#comment-15547870
]
Dawid Weiss commented on LUCENE-7465:
-
bq. Maybe we should explore an re2j version too.
I think it'd
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15546776#comment-15546776
]
Michael McCandless commented on LUCENE-7465:
Thank you for the example [~dweiss]. Indeed
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544822#comment-15544822
]
Dawid Weiss commented on LUCENE-7465:
-
On a happier note, if it's just a union of fixed-strings (a
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15544750#comment-15544750
]
Dawid Weiss commented on LUCENE-7465:
-
Hi Mike. Sorry it took me so long. So, check out this example
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15543441#comment-15543441
]
Adrien Grand commented on LUCENE-7465:
--
I like the separate factory idea better, it makes it easier
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525368#comment-15525368
]
Dawid Weiss commented on LUCENE-7465:
-
These regexps are generated from the data, so not so easy :)
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523315#comment-15523315
]
Michael McCandless commented on LUCENE-7465:
bq. default to current java regexp impl;
But I
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523032#comment-15523032
]
David Smiley commented on LUCENE-7465:
--
bq. I agree this would be nice, but my worry about taking
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523014#comment-15523014
]
Michael McCandless commented on LUCENE-7465:
Maybe you could share just the regexp :)
But,
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523000#comment-15523000
]
Dawid Weiss commented on LUCENE-7465:
-
I'll try to repeat the experiment with Lucene's regexp when I
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522997#comment-15522997
]
Dawid Weiss commented on LUCENE-7465:
-
I'll try to repeat the experiment with Lucene's regexp when I
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522992#comment-15522992
]
Michael McCandless commented on LUCENE-7465:
bq. Instead of adding another factory, what
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522972#comment-15522972
]
Michael McCandless commented on LUCENE-7465:
[~dawid.weiss] is this a benchmark I could try
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522947#comment-15522947
]
David Smiley commented on LUCENE-7465:
--
Instead of adding another factory, what about adding an
[
https://issues.apache.org/jira/browse/LUCENE-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522355#comment-15522355
]
Dawid Weiss commented on LUCENE-7465:
-
Interesting that it's faster than PatternTokenizer! I haven't
30 matches
Mail list logo
