[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876069#comment-15876069
]
ASF subversion and git services commented on LUCENE-7628:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876070#comment-15876070
]
ASF subversion and git services commented on LUCENE-7628:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872061#comment-15872061
]
Alan Woodward commented on LUCENE-7628:
---
Now that ToParentBlockJoinCollector is gone, I think I can
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834308#comment-15834308
]
Alan Woodward commented on LUCENE-7628:
---
The facet fix is simple enough (it's just in a test).
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834300#comment-15834300
]
ASF subversion and git services commented on LUCENE-7628:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834299#comment-15834299
]
ASF subversion and git services commented on LUCENE-7628:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834131#comment-15834131
]
ASF subversion and git services commented on LUCENE-7628:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834132#comment-15834132
]
ASF subversion and git services commented on LUCENE-7628:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830332#comment-15830332
]
Adrien Grand commented on LUCENE-7628:
--
I am still not fond of the change but I guess this is due to
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830268#comment-15830268
]
Alan Woodward commented on LUCENE-7628:
---
[~jpountz] are you happy with the patch as it is? We can
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824036#comment-15824036
]
Alan Woodward commented on LUCENE-7628:
---
Ah, I see what you mean. That would still work, I think,
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15824014#comment-15824014
]
Adrien Grand commented on LUCENE-7628:
--
I meant something similar to explain, which takes a docID,
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823821#comment-15823821
]
Alan Woodward commented on LUCENE-7628:
---
I'm not sure how moving the introspection API to Weight
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823736#comment-15823736
]
Adrien Grand commented on LUCENE-7628:
--
I think that would work, but Collector is another API where
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15823096#comment-15823096
]
Alan Woodward commented on LUCENE-7628:
---
I've reverted the change.
To keep the API the same size,
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822947#comment-15822947
]
Adrien Grand commented on LUCENE-7628:
--
I'm not sure about this change since it puts more pressure
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822766#comment-15822766
]
Alan Woodward commented on LUCENE-7628:
---
That sounds like an interesting idea,
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822372#comment-15822372
]
Paul Elschot commented on LUCENE-7628:
--
Hopefully this is not getting too far off topic.
In case
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15822361#comment-15822361
]
Paul Elschot commented on LUCENE-7628:
--
To continue about using Spans directly for this
(earlier
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819228#comment-15819228
]
Paul Elschot commented on LUCENE-7628:
--
I'll answer myself.
With AND and OR available, i.e. the
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819158#comment-15819158
]
Paul Elschot commented on LUCENE-7628:
--
And if there was also something like SpanAndMergeQuery that
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819109#comment-15819109
]
Alan Woodward commented on LUCENE-7628:
---
You can see the relevant code here:
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15819020#comment-15819020
]
Paul Elschot commented on LUCENE-7628:
--
bq. This all works correctly except in the case of a
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818614#comment-15818614
]
Alan Woodward commented on LUCENE-7628:
---
Turns out it's not as simple as just adding the method,
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818467#comment-15818467
]
Alan Woodward commented on LUCENE-7628:
---
Well, LUCENE-2878 is still open :)
Some of the luwak
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818456#comment-15818456
]
Dawid Weiss commented on LUCENE-7628:
-
bq. The luwak highlighter works by rewriting queries into
[
https://issues.apache.org/jira/browse/LUCENE-7628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15818451#comment-15818451
]
Alan Woodward commented on LUCENE-7628:
---
See also https://github.com/flaxsearch/luwak/issues/120,
27 matches
Mail list logo
