[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532645#comment-16532645
]
ASF subversion and git services commented on LUCENE-7976:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532646#comment-16532646
]
ASF subversion and git services commented on LUCENE-7976:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16522933#comment-16522933
]
Steve Rowe commented on LUCENE-7976:
{{git bisect}} blames commit {{2519025}} on this issue for the
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521359#comment-16521359
]
Steve Rowe commented on LUCENE-7976:
{{git blame}} points the finger at commit {{2519025}} on this
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514278#comment-16514278
]
Erick Erickson commented on LUCENE-7976:
I'm not quite sure what's happening, but my two recent
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514064#comment-16514064
]
Michael McCandless commented on LUCENE-7976:
OK I just chatted w/ [~erickerickson] and
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513252#comment-16513252
]
Lucene/Solr QA commented on LUCENE-7976:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512580#comment-16512580
]
Michael McCandless commented on LUCENE-7976:
{quote}maybe hop on a Google hangout or
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511577#comment-16511577
]
Erick Erickson commented on LUCENE-7976:
bq. maybe change to this?:
Sure. Next patch.
bq.
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511517#comment-16511517
]
Michael McCandless commented on LUCENE-7976:
bq. I don't think so. Since this is common
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510541#comment-16510541
]
Erick Erickson commented on LUCENE-7976:
bq. If we fix the above loop to not add the singleton
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510118#comment-16510118
]
Michael McCandless commented on LUCENE-7976:
Thanks [~erickerickson]; patch looks a lot
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507735#comment-16507735
]
Simon Willnauer commented on LUCENE-7976:
-
bq. I have no idea I saw the discussion at 8330 but
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16506594#comment-16506594
]
Erick Erickson commented on LUCENE-7976:
[~simonw]
bq. should we check here if the segDelDocs
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502206#comment-16502206
]
Erick Erickson commented on LUCENE-7976:
Simon:
Thanks, I'll be able to work on this sometime
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497857#comment-16497857
]
Simon Willnauer commented on LUCENE-7976:
-
{code:java}
+ // A singleton merge with no
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497581#comment-16497581
]
Erick Erickson commented on LUCENE-7976:
The failure was a bad test assumption, only a test
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496805#comment-16496805
]
Erick Erickson commented on LUCENE-7976:
Hit another failure (one in 2004), chasing now. Looks
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16496712#comment-16496712
]
Michael McCandless commented on LUCENE-7976:
Thanks [~erickerickson]; I'll look at the new
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495578#comment-16495578
]
Erick Erickson commented on LUCENE-7976:
Iteration N+1. This one removes the horrible loop that
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16490054#comment-16490054
]
Erick Erickson commented on LUCENE-7976:
[~mikemccand] OK, I'm back at it.
easy
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473280#comment-16473280
]
Erick Erickson commented on LUCENE-7976:
Mike:
Thanks, I'm off on vacation until the 22nd, then
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471009#comment-16471009
]
Michael McCandless commented on LUCENE-7976:
Net/net I like this change; it would allow the
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470787#comment-16470787
]
Michael McCandless commented on LUCENE-7976:
[~erickerickson] I'll review your latest patch
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470548#comment-16470548
]
Michael McCandless commented on LUCENE-7976:
{quote}I really think we should start working
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469931#comment-16469931
]
Erick Erickson commented on LUCENE-7976:
Latest patch incorporating comments so far and adding
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465852#comment-16465852
]
Simon Willnauer commented on LUCENE-7976:
-
> [~erickerickson] if you index with a single thread,
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465780#comment-16465780
]
Michael McCandless commented on LUCENE-7976:
[~erickerickson] if you index with a single
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465430#comment-16465430
]
Erick Erickson commented on LUCENE-7976:
[~simonw][~mikemccand] So I'm finally thinking about the
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464560#comment-16464560
]
Erick Erickson commented on LUCENE-7976:
Shawn:
Much of the point of this work is exactly to
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464414#comment-16464414
]
Shawn Heisey commented on LUCENE-7976:
--
General thoughts: I think the overall goals stated in the
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464399#comment-16464399
]
Shawn Heisey commented on LUCENE-7976:
--
I have not been following the code, but I have been
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464131#comment-16464131
]
Erick Erickson commented on LUCENE-7976:
Simon:
Thanks for taking the time, and yeah, the
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463704#comment-16463704
]
Simon Willnauer commented on LUCENE-7976:
-
here are a couple comments:
* please remove the
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463273#comment-16463273
]
Erick Erickson commented on LUCENE-7976:
[~mikemccand] Do note that I'm seeing these errors on my
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462618#comment-16462618
]
Michael McCandless commented on LUCENE-7976:
Thanks [~erickerickson]; I will try to review
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459460#comment-16459460
]
Erick Erickson commented on LUCENE-7976:
OK, I think this is getting quite close. The place I'm
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457885#comment-16457885
]
Erick Erickson commented on LUCENE-7976:
bq. I think it still makes sense to try to break these
Thanks Mike! It's great to have other eyes on it (and I'm taking a bit
of a break to come back at it with fresh eyes).
It'll be a bit before I can respond in detail. So far the latest patch
has successfully run through one full test iteration which is totally
inadequate before checking in of
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450110#comment-16450110
]
Michael McCandless commented on LUCENE-7976:
{quote} // We did our best to find the right
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450104#comment-16450104
]
Michael McCandless commented on LUCENE-7976:
{quote}Right, but that has quite a few
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449265#comment-16449265
]
Erick Erickson commented on LUCENE-7976:
Fix for the failing test
> Make TieredMergePolicy
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447548#comment-16447548
]
Erick Erickson commented on LUCENE-7976:
New patch with Mike's suggestions and most tests
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447344#comment-16447344
]
Erick Erickson commented on LUCENE-7976:
bq. not sure it's safe to remove that label yet
I'll
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447323#comment-16447323
]
Michael McCandless commented on LUCENE-7976:
{quote}About removing {{@lucene.experimental}},
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447046#comment-16447046
]
Erick Erickson commented on LUCENE-7976:
[~mikemccand] Thanks for looking!
About removing
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16447006#comment-16447006
]
Michael McCandless commented on LUCENE-7976:
This looks like it's coming together – thanks
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16446985#comment-16446985
]
Michael McCandless commented on LUCENE-7976:
It'd be great to have this simulator available
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16444213#comment-16444213
]
Erick Erickson commented on LUCENE-7976:
bq: Just curious, how did you go about measuring that?
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443559#comment-16443559
]
David Smiley commented on LUCENE-7976:
--
{quote}On a relatively quick test, setting
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443506#comment-16443506
]
Erick Erickson commented on LUCENE-7976:
I'm much more optimisitc about this approach. What this
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441001#comment-16441001
]
Erick Erickson commented on LUCENE-7976:
Hold the presses. I really, really, really _hate_ it
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16439785#comment-16439785
]
Erick Erickson commented on LUCENE-7976:
Well, it didn't get simpler ;(...
[~mikemccand] The
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429447#comment-16429447
]
Erick Erickson commented on LUCENE-7976:
Oh, and Mike (and others):
Please don't go over this
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429433#comment-16429433
]
Erick Erickson commented on LUCENE-7976:
Thanks for taking the time Mike! Going in reverse order:
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429059#comment-16429059
]
Michael McCandless commented on LUCENE-7976:
I think this change might be cleaner if we can
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429054#comment-16429054
]
Michael McCandless commented on LUCENE-7976:
I'm confused what this means:
{quote}I further
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429038#comment-16429038
]
Michael McCandless commented on LUCENE-7976:
Phew suddenly a lot of action here! I'll review
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428991#comment-16428991
]
Erick Erickson commented on LUCENE-7976:
[~mikemccand] re: do you know the condition in
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16428605#comment-16428605
]
Erick Erickson commented on LUCENE-7976:
Marc:
Thanks for looking, especially at how jumbled the
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427982#comment-16427982
]
Marc Morissette commented on LUCENE-7976:
-
[~erickerickson] Thanks for tackling this.
Regarding
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427892#comment-16427892
]
Erick Erickson commented on LUCENE-7976:
One more thing. The current patch doesn't deal at all
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427789#comment-16427789
]
Erick Erickson commented on LUCENE-7976:
[~mikemccand] do you know the condition in
[
https://issues.apache.org/jira/browse/LUCENE-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427642#comment-16427642
]
Erick Erickson commented on LUCENE-7976:
This is coming together, here's a preliminary patch. It
64 matches
Mail list logo
