[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-08-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597034#comment-16597034 ] ASF subversion and git services commented on LUCENE-8286: - Commit

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-08-29 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597019#comment-16597019 ] ASF subversion and git services commented on LUCENE-8286: - Commit

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-08-27 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593692#comment-16593692 ] David Smiley commented on LUCENE-8286: -- _The PR is ready to go I think._ I'll commit in a couple

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-08-13 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578835#comment-16578835 ] David Smiley commented on LUCENE-8286: -- Actually before continuing with any of that, I think the PR

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-08-13 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16578802#comment-16578802 ] David Smiley commented on LUCENE-8286: -- Made substantial progress to the PR: {noformat} LUCENE-8286

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-07-11 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540745#comment-16540745 ] David Smiley commented on LUCENE-8286: -- I updated the PR significantly. It addresses

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-06-24 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521825#comment-16521825 ] David Smiley commented on LUCENE-8286: -- I pushed the patch to GitHub as a linked PR.  The only

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-06-10 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507691#comment-16507691 ] David Smiley commented on LUCENE-8286: -- The first patch here is my working WIP. Everything

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-05-03 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462466#comment-16462466 ] David Smiley commented on LUCENE-8286: -- The "span" width _could_ be used for passage relevancy, and

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-05-03 Thread Adrien Grand (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16462361#comment-16462361 ] Adrien Grand commented on LUCENE-8286: -- bq. MI has things we don't need – position spans I don't

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-05-02 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461646#comment-16461646 ] David Smiley commented on LUCENE-8286: -- {quote}there is no way to retrieve the term/query in the

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-05-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461226#comment-16461226 ] Alan Woodward commented on LUCENE-8286: --- There's an API mismatch in how offsets are retrieved,

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-05-02 Thread Jim Ferenczi (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16461105#comment-16461105 ] Jim Ferenczi commented on LUCENE-8286: -- I also think that it would greatly simplify the code

[jira] [Commented] (LUCENE-8286) UnifiedHighlighter should support the new Weight.matches API for better match accuracy

2018-05-01 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459899#comment-16459899 ] David Smiley commented on LUCENE-8286: -- Per chance do you have any WIP code for this or do any