[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498892#comment-16498892 ] ASF subversion and git services commented on SOLR-12290: Commit

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16498886#comment-16498886 ] ASF subversion and git services commented on SOLR-12290: Commit

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494006#comment-16494006 ] Varun Thacker commented on SOLR-12290: -- Hi Mark, I committed it and looks like the author tag was

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493988#comment-16493988 ] ASF subversion and git services commented on SOLR-12290: Commit

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492978#comment-16492978 ] Varun Thacker commented on SOLR-12290: -- Sounds good! Here's a patch which squashes all the 4 commits

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492948#comment-16492948 ] Mark Miller commented on SOLR-12290: Yeah, feel free - the reason I’m not very concerned is that the

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16492883#comment-16492883 ] Varun Thacker commented on SOLR-12290: -- Hi Mark, Is it okay if we backport this to branch_7x  ?

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472912#comment-16472912 ] ASF subversion and git services commented on SOLR-12290: Commit

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472902#comment-16472902 ] ASF subversion and git services commented on SOLR-12290: Commit

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465479#comment-16465479 ] Uwe Schindler commented on SOLR-12290: -- Hi, I can backport this if needed. I'd just like to have a

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465335#comment-16465335 ] Mark Miller commented on SOLR-12290: bq. See my comment. But some things have to be said. Introducing

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465334#comment-16465334 ] Mark Miller commented on SOLR-12290: This wasn't about coding practices - it's simply about the

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465331#comment-16465331 ] David Smiley commented on SOLR-12290: - Last commit to partially revert looks good to me.  I agree with

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465280#comment-16465280 ] Uwe Schindler commented on SOLR-12290: -- See my comment. But some things have to be said. Introducing

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465277#comment-16465277 ] Mark Miller commented on SOLR-12290: bq. Oh thanks, that was my patch Your welcome. If you insist on

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465276#comment-16465276 ] Uwe Schindler commented on SOLR-12290: -- Sorry, I am a bit worried today. It's too hot here and it was

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465271#comment-16465271 ] Mark Miller commented on SOLR-12290: You definitely bring a nasty Lucene vibe into the Solr community

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465269#comment-16465269 ] Uwe Schindler commented on SOLR-12290: -- Oh thanks, that was my patch :-) > Do not close any servlet

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465267#comment-16465267 ] ASF subversion and git services commented on SOLR-12290: Commit

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465255#comment-16465255 ] Uwe Schindler commented on SOLR-12290: -- As you are not willing to fix this, should I send you the

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465254#comment-16465254 ] Uwe Schindler commented on SOLR-12290: -- bq. Whether Jetty closed the socket or not, we can't have

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465252#comment-16465252 ] Uwe Schindler commented on SOLR-12290: -- It's not only CSV handler. It's all code that consumes

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465249#comment-16465249 ] Mark Miller commented on SOLR-12290: Because we no longer have two separate code paths for tests and

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465248#comment-16465248 ] Uwe Schindler commented on SOLR-12290: -- I think your patch is fine. Really just revert the code that

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465244#comment-16465244 ] Uwe Schindler commented on SOLR-12290: -- I have seen. It's fine! I was just really annoyed today while

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465241#comment-16465241 ] Mark Miller commented on SOLR-12290: I will look into this Uwe. We are still using a CloseShield.

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465240#comment-16465240 ] Uwe Schindler commented on SOLR-12290: -- I think I know how to solve this: - Revert all stuf that

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465237#comment-16465237 ] Uwe Schindler commented on SOLR-12290: -- I just repeat: We have no a serious file descriptor leak in

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465235#comment-16465235 ] Uwe Schindler commented on SOLR-12290: -- This commit breaks TestCSVLoader on Windows. It looks like

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464484#comment-16464484 ] ASF subversion and git services commented on SOLR-12290: Commit

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460143#comment-16460143 ] Mark Miller commented on SOLR-12290: For a long term strategy to improve all of this yet again (of

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458676#comment-16458676 ] Mark Miller commented on SOLR-12290: As I've been working on this, I realized that we don't ensure

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458594#comment-16458594 ] Mark Miller commented on SOLR-12290: Yeah, it’s not super obvious, but the problem with closing

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458566#comment-16458566 ] David Smiley commented on SOLR-12290: - Sounds good Mark!  Thanks for the clarifications.  I didn't

[jira] [Commented] (SOLR-12290) Do not close any servlet streams and improve our servlet stream closing prevention code for users and devs.

[ https://issues.apache.org/jira/browse/SOLR-12290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16458314#comment-16458314 ] Mark Miller commented on SOLR-12290: bq. JavabinLoader: you can now inline parseAndLoadDocs Inlined.