[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2018-12-05 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16710613#comment-16710613 ] Ben Manes commented on SOLR-8241: - Another year, another ping! Do you think that you'll have some time

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2017-12-30 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307000#comment-16307000 ] Ben Manes commented on SOLR-8241: - Shawn, is this issue something you'd be interested in finalizing in the

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2017-02-17 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872244#comment-15872244 ] Ben Manes commented on SOLR-8241: - [~Timothy055], solr master is now on 2.3.5 (to upgrade its usage in the

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2017-01-25 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839058#comment-15839058 ] Ben Manes commented on SOLR-8241: - [~elyograg]: Solr 6.4.0 was just released. Do you think we can make a

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2017-01-05 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802076#comment-15802076 ] Ben Manes commented on SOLR-8241: - I think the tests all passed last I checked with this new SolrCache, but

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2017-01-05 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802010#comment-15802010 ] Shawn Heisey commented on SOLR-8241: This issue was filed by the author of Caffeine (Ben Manes) and

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2017-01-05 Thread Timothy M. Rodriguez (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801792#comment-15801792 ] Timothy M. Rodriguez commented on SOLR-8241: +1 for this issue. Solr currently uses

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-10-08 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558709#comment-15558709 ] Ben Manes commented on SOLR-8241: - I think there is a small bug in the "hottest" ordering provided by

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-10-08 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558521#comment-15558521 ] Ben Manes commented on SOLR-8241: - I can take a stab at tests, but its unclear what to include other than

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-10-08 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558485#comment-15558485 ] Shawn Heisey commented on SOLR-8241: Taking a look at this today. Would you be able to build some

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-25 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521377#comment-15521377 ] Ben Manes commented on SOLR-8241: - I took look to refresh myself on LFUCache and decay. I don't think there

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517521#comment-15517521 ] Ben Manes commented on SOLR-8241: - The cache does provide basic snapshot features ordered by the policy

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517462#comment-15517462 ] Shawn Heisey commented on SOLR-8241: Each searcher has its own cache instances. It needs to have

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517433#comment-15517433 ] Ben Manes commented on SOLR-8241: - Can you explain why a new instance is required and the entire cache

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517418#comment-15517418 ] Shawn Heisey commented on SOLR-8241: It's been so long since I wrote LFUCache that I'm having a hard

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517094#comment-15517094 ] Ben Manes commented on SOLR-8241: - Expiration is tricky because it means the data is no longer valid to be

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517090#comment-15517090 ] Ben Manes commented on SOLR-8241: - Expiration is tricky because it means the data is no longer valid to be

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517065#comment-15517065 ] Shawn Heisey commented on SOLR-8241: Decay (as implemented) can't be *completely* replaced by

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-09-23 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517021#comment-15517021 ] Shawn Heisey commented on SOLR-8241: After some experience using Caffeine in my own code, I think it's

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-07-16 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381077#comment-15381077 ] Ben Manes commented on SOLR-8241: - Can we try to move this forward again? Thanks! > Evaluate W-TinyLfu

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-04-12 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238184#comment-15238184 ] Ben Manes commented on SOLR-8241: - Thanks for the information. I definitely meant that would be a new issue

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-04-12 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237993#comment-15237993 ] Shawn Heisey commented on SOLR-8241: Those are Lucene caches. The first one is in Lucene core. The

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-04-12 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237765#comment-15237765 ] Ben Manes commented on SOLR-8241: - There are some other caches that might be worth migrating as well (e.g.

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-04-11 Thread Jeff Wartes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235935#comment-15235935 ] Jeff Wartes commented on SOLR-8241: --- Since Solr requires Java 8 as of 6.0, it seems like this patch could

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-03-03 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178872#comment-15178872 ] Ben Manes commented on SOLR-8241: - Percentile stats are best obtained by the metrics library. The stats

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-03-03 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178727#comment-15178727 ] Shawn Heisey commented on SOLR-8241: bq. neither Guava or Caffeine bothered to include a {{put}}

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-03-03 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178389#comment-15178389 ] Ben Manes commented on SOLR-8241: - Using the metrics library should be really easy. There are two simple

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-03-03 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178352#comment-15178352 ] Shawn Heisey commented on SOLR-8241: I'm pretty sure that no matter what benchmarks we run, your

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-03-03 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178106#comment-15178106 ] Ben Manes commented on SOLR-8241: - I see that [YCSB|https://github.com/brianfrankcooper/YCSB] includes Solr

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-02-08 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137111#comment-15137111 ] Shawn Heisey commented on SOLR-8241: If this proves to be advantageous, it would be my recommendation

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-02-08 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136695#comment-15136695 ] Ben Manes commented on SOLR-8241: - Attached a patch that includes a new SolrCache implementation based on

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-02-08 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137321#comment-15137321 ] Ben Manes commented on SOLR-8241: - I only used the LruCache as a template and removed much of it, though

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2016-02-08 Thread David Smiley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137458#comment-15137458 ] David Smiley commented on SOLR-8241: +1 Cool work Ben! I like the relative simplicity and low amount

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2015-12-22 Thread Shawn Heisey (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069229#comment-15069229 ] Shawn Heisey commented on SOLR-8241: ARC was a cache type that I had read about when I went looking for

[jira] [Commented] (SOLR-8241) Evaluate W-TinyLfu cache

2015-12-22 Thread Ben Manes (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15069335#comment-15069335 ] Ben Manes commented on SOLR-8241: - [Benchmarks|https://github.com/ben-manes/caffeine/wiki/Benchmarks] of