Re: GC cost of creating String resource description on IndexInput clone

2021-02-22 Thread Viral Gandhi
>> >> In addition, the strings are not for debugging, they are really useful >> when something goes wrong, e.g. when I/O errors occur. >> >> >> >> Uwe >> >> >> >> - >> >> Uwe Schindler >> >> Achterdiek 19, D

Re: GC cost of creating String resource description on IndexInput clone

2021-02-20 Thread Robert Muir
gs are not for debugging, they are really useful > when something goes wrong, e.g. when I/O errors occur. > > > > Uwe > > > > - > > Uwe Schindler > > Achterdiek 19, D-28357 Bremen > > https://www.thetaphi.de > > eMail: u...@thetaphi.de > &g

RE: GC cost of creating String resource description on IndexInput clone

2021-02-20 Thread Uwe Schindler
, February 20, 2021 12:17 PM To: 'dev@lucene.apache.org' Subject: RE: GC cost of creating String resource description on IndexInput clone Hi, I was thinking about something similar when working on the Java 17 replacement for MMapDirectory. My idea would still be late evaluation, but using a lambda

RE: GC cost of creating String resource description on IndexInput clone

2021-02-20 Thread Uwe Schindler
Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de From: Robert Muir Sent: Saturday, February 20, 2021 11:56 AM To: dev@lucene.apache.org Subject: Re: GC cost of creating String resource description on IndexInput clone The issue is that cl

Re: GC cost of creating String resource description on IndexInput clone

2021-02-20 Thread Robert Muir
The issue is that clone or not, they are both IndexInput.java. So if we go with your proposal, then *sometimes* the code will have this reference and *other times* it won't and the reference will be null. In that non-clone case, where would its resource description (filename) come from? I predict

Re: GC cost of creating String resource description on IndexInput clone

2021-02-19 Thread Mike Drob
Late evaluation sounds like it would definitely be nice, but I worry about holding on to object instances longer than necessary might lead to memory leaks. Sounds like a good issue to open on JIRA. On Fri, Feb 19, 2021 at 3:58 PM Viral Gandhi wrote: > Hello everyone, > > We recently added Java