[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera closed LUCENE-7853.
Change applied.
Thanks!
> Request to change visibility of classes in geo3d
>
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031839#comment-16031839
]
Karl Wright commented on LUCENE-7853:
-
Anything that helps is great!
> Request to change visibility
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031796#comment-16031796
]
Christine Poerschke commented on LUCENE-7853:
-
LUCENE-7858 to refine the 'broken links'
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031768#comment-16031768
]
Hoss Man commented on LUCENE-7853:
--
bq. Precommit is complaining about references from GeoPoint etc.
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031751#comment-16031751
]
ASF subversion and git services commented on LUCENE-7853:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031746#comment-16031746
]
ASF subversion and git services commented on LUCENE-7853:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031719#comment-16031719
]
Karl Wright commented on LUCENE-7853:
-
[~hossman]: If that's the problem it is unclear from
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright updated LUCENE-7853:
Comment: was deleted
(was: Looks like the javadoc is now being invoked in a way where it doesn't
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright resolved LUCENE-7853.
-
Resolution: Fixed
> Request to change visibility of classes in geo3d
>
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031704#comment-16031704
]
Karl Wright commented on LUCENE-7853:
-
Looks like the javadoc is now being invoked in a way where it
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031666#comment-16031666
]
Hoss Man commented on LUCENE-7853:
--
Huh?
You just changed GeoPolygonFactory a few hours ago, and added
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031648#comment-16031648
]
Karl Wright commented on LUCENE-7853:
-
[~hossman]: This is odd because it's complaining about stuff
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man reopened LUCENE-7853:
--
precommit failures from documentation-lint...
{noformat}
[echo] checking for broken html...
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright resolved LUCENE-7853.
-
Resolution: Fixed
Fix Version/s: 6.7
master (7.0)
> Request to change
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031047#comment-16031047
]
ASF subversion and git services commented on LUCENE-7853:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031044#comment-16031044
]
ASF subversion and git services commented on LUCENE-7853:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031037#comment-16031037
]
Karl Wright commented on LUCENE-7853:
-
[~ivera]: looks good to me. I will commit.
> Request to
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-7853:
-
Attachment: LUCENE-7853.patch
Attached a new patch with updated documentation. I hope this is
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-7853:
-
Attachment: (was: LUCENE-7853.patch)
> Request to change visibility of classes in geo3d
>
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029535#comment-16029535
]
Ignacio Vera commented on LUCENE-7853:
--
[~daddywri]: You are totally right, the order of the points
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029468#comment-16029468
]
Karl Wright commented on LUCENE-7853:
-
[~ivera]: A composite polygon isn't appreciably slower than a
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029353#comment-16029353
]
Ignacio Vera commented on LUCENE-7853:
--
New patch attached, this time looks what you expect I hope.
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-7853:
-
Attachment: LUCENE-7853.patch
> Request to change visibility of classes in geo3d
>
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-7853:
-
Attachment: (was: LUCENE-7853.patch)
> Request to change visibility of classes in geo3d
>
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029271#comment-16029271
]
Karl Wright commented on LUCENE-7853:
-
[~ivera], the patch seems to not be generated against master;
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ignacio Vera updated LUCENE-7853:
-
Attachment: LUCENE-7853.patch
Attached is that patch.
One thing I noticed is that when I call
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026264#comment-16026264
]
Ignacio Vera commented on LUCENE-7853:
--
Do you see any isuue with the following proposal:
I would
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026179#comment-16026179
]
Ignacio Vera commented on LUCENE-7853:
--
Hi [~daddywri],
I agree with your apporach and yes I can
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026134#comment-16026134
]
Karl Wright commented on LUCENE-7853:
-
Hi [~ivera], I'd be happy to help with this. I'd prefer the
[
https://issues.apache.org/jira/browse/LUCENE-7853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Wright reassigned LUCENE-7853:
---
Assignee: Karl Wright
> Request to change visibility of classes in geo3d
>
You could also solve this by adding additional unchecked factory methods,
no? I'm afraid Robert will not be too pleased with generally opening
things up.
Karl
On Fri, May 26, 2017 at 6:17 AM, Ignacio Vera Sequeiros
wrote:
> Done.
>
>
>
> Cheers,
>
>
>
> Ignacio Vera
>
>
>
>
Done.
Cheers,
Ignacio Vera
From: Michael McCandless [mailto:luc...@mikemccandless.com]
Sent: Friday, May 26, 2017 11:02 AM
To: Lucene/Solr dev ; Ignacio Vera Sequeiros
Subject: Re: Request to change visibility of classes in geo3d
I think that makes
Ignacio Vera created LUCENE-7853:
Summary: Request to change visibility of classes in geo3d
Key: LUCENE-7853
URL: https://issues.apache.org/jira/browse/LUCENE-7853
Project: Lucene - Core
I think that makes sense; can you open a Jira issue? Thanks.
Mike McCandless
http://blog.mikemccandless.com
On Fri, May 26, 2017 at 4:46 AM, Ignacio Vera Sequeiros
wrote:
> Hi,
>
>
>
> I am creating my own spatial context by wrapping the objects in lucene
> geo3d library and
Hi,
I am creating my own spatial context by wrapping the objects in lucene geo3d
library and implement my own query which mixes the recursive and the serialized
strategy to add precision to searches.
I had the following issue specially with polygons: The factory for creating
polygons is
35 matches
Mail list logo